Skip to content

[SPARK-31797][SQL] Adds TIMESTAMP_SECONDS, TIMESTAMP_MILLIS and TIMESTAMP_MICROS functions #28534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TJX2014 wants to merge 18 commits into from
Closed

[SPARK-31797][SQL] Adds TIMESTAMP_SECONDS, TIMESTAMP_MILLIS and TIMESTAMP_MICROS functions #28534

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
5e60ec5
SPARK-31710: TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_…
TJX2014 May 19, 2020
27a162b
improve code quality according to advices
TJX2014 May 20, 2020
f879987
code style improved and remove bad asInstanceOf etc
TJX2014 May 20, 2020
4c17d49
From a readability perspective it may be better to put the base class…
TJX2014 May 20, 2020
3411935
new exception check when overflow occur when multiply long and more p…
TJX2014 May 20, 2020
17a33f5
long overflow in datetime.sql added and pass the local test
TJX2014 May 20, 2020
344e5e1
test overflow condition fix, just small unit for per test
TJX2014 May 20, 2020
407dcfc
fix unit test failed due to string value in ExpressionDescription
TJX2014 May 20, 2020
944c644
regenerate sql-expression-schema.md
TJX2014 May 20, 2020
642668c
minimize code gen by judge equal 1 and remove duplicate unit test
TJX2014 May 20, 2020
62bf8b5
correct style of usage content
TJX2014 May 21, 2020
7da94b5
short name to MillisToTimestamp and MicrosToTimestamp
TJX2014 May 21, 2020
3704fee
correct short name in sql-expression-schema.md
TJX2014 May 21, 2020
f5b0a5a
function rename timestamp_microseconds to timestamp_micros and timest…
TJX2014 May 21, 2020
f4f7c35
disable cast string to long in number to timestamp
TJX2014 May 21, 2020
3c949ac
regenerate sql-expression-schema.md, UT added in DateExpressionsSuite
TJX2014 May 22, 2020
fdfd75c
UT style improve
TJX2014 May 22, 2020
f0cc631
UT style improve
TJX2014 May 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
correct style of usage content
  • Loading branch information
@TJX2014
TJX2014 committed May 22, 2020
commit 62bf8b51701cc4287604f146f0ec7688d04876eb
10 changes: 6 additions & 4 deletions ...talyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -440,16 +440,17 @@ case class SecondsToTimestamp(child: Expression)
override def prettyName: String = "timestamp_seconds"
}

// scalastyle:off line.size.limit
@ExpressionDescription(
usage = "_FUNC_(milliseconds) - " +
"Creates timestamp from the number of milliseconds since UTC epoch.",
usage = "_FUNC_(milliseconds) - Creates timestamp from the number of milliseconds since UTC epoch.",
examples = """
Examples:
> SELECT _FUNC_(1230219000123);
2008-12-25 07:30:00.123
""",
group = "datetime_funcs",
since = "3.1.0")
// scalastyle:on line.size.limit
case class MilliSecondsToTimestamp(child: Expression)
extends NumberToTimestampBase {

Expand All @@ -458,16 +459,17 @@ case class MilliSecondsToTimestamp(child: Expression)
override def prettyName: String = "timestamp_milliseconds"
}

// scalastyle:off line.size.limit
@ExpressionDescription(
usage = "_FUNC_(microseconds) - " +
"Creates timestamp from the number of microseconds since UTC epoch.",
usage = "_FUNC_(microseconds) - Creates timestamp from the number of microseconds since UTC epoch.",
examples = """
Examples:
> SELECT _FUNC_(1230219000123123);
2008-12-25 07:30:00.123123
""",
group = "datetime_funcs",
since = "3.1.0")
// scalastyle:on line.size.limit
case class MicroSecondsToTimestamp(child: Expression)
extends NumberToTimestampBase {

Expand Down