[SPARK-31757][CORE] Improve HistoryServerDiskManager.updateAccessTime() #28579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiangxb1987
commented
May 19, 2020
| } | ||
|
|
||
| private def updateAccessTime(appId: String, attemptId: Option[String]): Unit = { | ||
| private def updateApplicationStoreInfo( |
Contributor
Author
There was a problem hiding this comment.
This function updates both the lastAccess time and the size, so it would be better to rename to updateApplicationStoreInfo.
|
Test build #122840 has finished for PR 28579 at commit
|
Contributor
Author
|
retest this please |
|
Test build #122853 has finished for PR 28579 at commit
|
Contributor
Author
|
retest this please |
|
Test build #122951 has finished for PR 28579 at commit
|
Contributor
Author
|
Thanks, merged to master! |
HeartSaVioR
pushed a commit
to HeartSaVioR/spark
that referenced
this pull request
Jul 8, 2020
### What changes were proposed in this pull request? The function `HistoryServerDiskManager`.`updateAccessTime()` would recompute the application store directory size every time it's triggered, this effort could be avoided because we already computed the new size outside the function call. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Existing test cases. Closes apache#28579 from jiangxb1987/updateInfo. Authored-by: Xingbo Jiang <[email protected]> Signed-off-by: Xingbo Jiang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The function
HistoryServerDiskManager.updateAccessTime()would recompute the application store directory size every time it's triggered, this effort could be avoided because we already computed the new size outside the function call.Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing test cases.