[SPARK-31764][CORE] JsonProtocol doesn't write RDDInfo#isBarrier #28583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #122855 has started for PR 28583 at commit |
Member
Author
|
Test seems to be aborted. |
Member
Author
|
retest this please. |
|
Test build #122919 has finished for PR 28583 at commit
|
|
Test build #122927 has finished for PR 28583 at commit
|
Contributor
|
cc. @jiangxb1987 This is newly added in Spark 3.0.0, which is ideal to be addressed in 3.0.0 if possible. |
seanli-rallyhealth
approved these changes
May 25, 2020
Contributor
|
retest this please |
|
Test build #123139 has finished for PR 28583 at commit
|
Contributor
|
retest this please |
|
Test build #123200 has finished for PR 28583 at commit
|
Contributor
|
Thanks, merged to master! |
sarutak
added a commit
to sarutak/spark
that referenced
this pull request
May 28, 2020
### What changes were proposed in this pull request? This PR changes JsonProtocol to write RDDInfos#isBarrier. ### Why are the changes needed? JsonProtocol reads RDDInfos#isBarrier but not write it so it's a bug. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? I added a testcase. Closes apache#28583 from sarutak/SPARK-31764. Authored-by: Kousuke Saruta <[email protected]> Signed-off-by: Xingbo Jiang <[email protected]>
jiangxb1987
pushed a commit
that referenced
this pull request
Jun 1, 2020
### What changes were proposed in this pull request? This PR backports the change of #28583 (SPARK-31764) to branch-3.0, which changes JsonProtocol to write RDDInfos#isBarrier. ### Why are the changes needed? JsonProtocol reads RDDInfos#isBarrier but not write it so it's a bug. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? I added a testcase. Closes #28660 from sarutak/SPARK-31764-branch-3.0. Authored-by: Kousuke Saruta <[email protected]> Signed-off-by: Xingbo Jiang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR changes JsonProtocol to write RDDInfos#isBarrier.
Why are the changes needed?
JsonProtocol reads RDDInfos#isBarrier but not write it so it's a bug.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
I added a testcase.