[SPARK-31778][K8S][BUILD] Support cross-building docker images

[holdenk]

What changes were proposed in this pull request?

Add cross build support to our docker image script using the new dockerx extension.

Why are the changes needed?

We have a CI for Spark on ARM, we should support building images for ARM and AMD64.

Does this PR introduce any user-facing change?

Yes, a new flag is added to the docker image build script to cross-build

How was this patch tested?

Manually ran build script & pushed to https://hub.docker.com/repository/registry-1.docker.io/holdenk/spark/tags?page=1 verified amd64 & arm64 listed.

[SparkQA]

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/27656/

[SparkQA]

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/27656/

[SparkQA]

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/27657/

[SparkQA]

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/27657/

[SparkQA]

Test build #123013 has finished for PR 28615 at commit f7fdddc.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[SparkQA]

Test build #123014 has finished for PR 28615 at commit ea0769d.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[dongjoon-hyun]

This doesn't work on Docker Desktop. I tested on the latest one, Docker Desktop Edge 2020-05-20 2.3.1.0. In this case, we had better describe the limitation of this new feature. Could you describe the used and expected environment in your PR description?

$ bin/docker-image-tool.sh -r docker.io/myrepo -t v3.0.0 -X -b java_image_tag=11-jre-slim build
...
+ docker buildx build --platform linux/amd64,linux/arm64 --build-arg java_image_tag=11-jre-slim -t docker.io/myrepo/spark:v3.0.0 -f kubernetes/dockerfiles/spark/Dockerfile .
multiple platforms feature is currently not supported for docker driver. Please switch to a different driver (eg. "docker buildx create --use")

[holdenk]

It does work on docker desktop but you need to be setup to cross build (currently experimental). I'll add a link in the script for those instructions.

[SparkQA]

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/27705/

[SparkQA]

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/27705/

[SparkQA]

Test build #123068 has finished for PR 28615 at commit e5176c7.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[dongjoon-hyun]

Thank you for updating. Given the new URL at the last commit, it seems that this feature is pretty immature. Can we wait until it become stable?

BTW, I've also been in experimental mode as described in the doc, but the situation is the same. If this is not working at out-of-box status, the single URL looks insufficient to support this PR.

$ cat ~/.docker/config.json | grep experimental
  "experimental" : "enabled",

[holdenk]

Cross building is relatively new, but a lot of docker images are cross built already. It’s optional and disabled by default (eg to have this build you’d have to explicitly configure it).

For example the JDK11 base image is already cross built on amd64 and aarm64.

You need to follow the buildx setup instructions not just turn on the expiremental channel.

[dongjoon-hyun]

Okay. I removed my previous change request.
I'll leave this to the other reviewers then. Thanks.

I removed my previous comment.