-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-31804][WEBUI] Add real headless browser support for HistoryServer tests #28622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-31804][WEBUI] Add real headless browser support for HistoryServer tests #28622
Conversation
|
Test build #123033 has finished for PR 28622 at commit
|
|
Test build #123034 has finished for PR 28622 at commit
|
srowen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just checking - will existing tests still run on our amplab Jenkins instances then? I see that they get disabled without chromedriver.
|
Existing tests in |
|
Please hold on this because the original PR breaks master branch. This can propagate the failures into new suites. Please see #28578 (comment) . |
|
retest this please |
|
@HyukjinKwon Thanks for taking a look at this. Tests in this PR will fail until #28627 is merged because this PR doesn't contain the way to skip suites with the tag |
|
Test build #123047 has finished for PR 28622 at commit
|
|
Oh, I see. Thanks :D. |
…s-browser-support-for-historyserver
|
|
|
Test build #123307 has finished for PR 28622 at commit
|
|
@sarutak to be clear we can merge this, or does another need to come first? |
|
Now we can merge this and the next is #28585. |
|
Merged to master |
What changes were proposed in this pull request?
This PR adds two things.
Real headless browser support for HistoryServer tests.
A test suite using headless Chrome as one instance of those browsers.
Why are the changes needed?
The motivation is same as #28578 .
In the current master, there is a testcase for HistoryServer which uses Ajax so we need the support for HistoryServer tests.
Also this change is necessary to upgrade HtmlUnit (See #28585)
Does this PR introduce any user-facing change?
No.
How was this patch tested?
I tested with following patterns. Both Chrome and Chrome driver should be installed to test.
sbt / with default excluded tags (ChromeUIHistoryServerSuite is expected to be skipped and SQLQueryTestSuite is expected to succeed)
`build/sbt -Dspark.test.webdriver.chrome.driver=/path/to/chromedriver "testOnly org.apache.spark.deploy.history.ChromeUIHistoryServerSuite org.apache.spark.sql.SQLQueryTestSuite"
sbt / overwrite default excluded tags as empty string (Both suites are expected to succeed)
`build/sbt -Dtest.default.exclude.tags= -Dspark.test.webdriver.chrome.driver=/path/to/chromedriver "testOnly org.apache.spark.deploy.history.ChromeUIHistoryServerSuite org.apache.spark.sql.SQLQueryTestSuite"
sbt / set
test.exclude.tagstoorg.apache.spark.tags.ExtendedSQLTest(Both suites are expected to be skipped)`build/sbt -Dtest.exclude.tags=org.apache.spark.tags.ExtendedSQLTest -Dspark.test.webdriver.chrome.driver=/path/to/chromedriver "testOnly org.apache.spark.deploy.history.ChromeUIHistoryServerSuite org.apache.spark.sql.SQLQueryTestSuite"
Maven / with default excluded tags (ChromeUIHistoryServerSuite is expected to be skipped and SQLQueryTestSuite is expected to succeed)
build/mvn -Dspark.test.webdriver.chrome.driver=/path/to/chromedriver -Dtest=none -DwildcardSuites=org.apache.spark.deploy.history.ChromeUIHistoryServerSuite,org.apache.spark.sql.SQLQueryTestSuite testMaven / overwrite default excluded tags as empty string (Both suites are expected to succeed)
build/mvn -Dtest.default.exclude.tags= -Dspark.test.webdriver.chrome.driver=/path/to/chromedriver -Dtest=none -DwildcardSuites=org.apache.spark.deploy.history.ChromeUIHistoryServerSuite,org.apache.spark.sql.SQLQueryTestSuite testMaven / set
test.exclude.tagstoorg.apache.spark.tags.ExtendedSQLTest(Both suites are expected to be skipped)build/mvn -Dtest.exclude.tags=org.apache.spark.tags.ExtendedSQLTest -Dspark.test.webdriver.chrome.driver=/path/to/chromedriver -Dtest=none -DwildcardSuites=org.apache.spark.deploy.history.ChromeUIHistoryServerSuite,org.apache.spark.sql.SQLQueryTestSuite test