Skip to content

[SPARK-28481][SQL] More expressions should extend NullIntolerant #28626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wangyum wants to merge 8 commits into from
Closed

[SPARK-28481][SQL] More expressions should extend NullIntolerant #28626

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
fb68d60
More expressions should extend NullIntolerant
wangyum May 24, 2020
c3625ca
Fix build error
wangyum May 24, 2020
7fe3490
Move checker to ExpressionInfoSuite
wangyum May 24, 2020
2c943cc
Merge remote-tracking branch 'upstream/master' into SPARK-28481
wangyum May 26, 2020
b127c41
fix
wangyum May 26, 2020
82e97e3
fix typo
wangyum May 26, 2020
1bdff95
Address comment
wangyum May 28, 2020
265abd3
revert
wangyum May 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix typo
  • Loading branch information
@wangyum
wangyum committed May 26, 2020
commit 82e97e34f46f0b01c9fc49d25aa7bb1a76e140eb
2 changes: 1 addition & 1 deletion ...alyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3224,7 +3224,7 @@ case class ArrayDistinct(child: Expression)
* Will become common base class for [[ArrayUnion]], [[ArrayIntersect]], and [[ArrayExcept]].
*/
trait ArrayBinaryLike
extends BinaryArrayExpressionWithImplicitCast with ArraySetLike with NullIntolerant{
extends BinaryArrayExpressionWithImplicitCast with ArraySetLike with NullIntolerant {
override protected def dt: DataType = dataType
override protected def et: DataType = elementType

Expand Down
6 changes: 3 additions & 3 deletions ...catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,7 +357,7 @@ case class Upper(child: Expression)
""",
since = "1.0.1")
case class Lower(child: Expression)
extends UnaryExpression with String2StringExpression with NullIntolerant{
extends UnaryExpression with String2StringExpression with NullIntolerant {

// scalastyle:off caselocale
override def convert(v: UTF8String): UTF8String = v.toLowerCase
Expand Down Expand Up @@ -1741,7 +1741,7 @@ case class Left(str: Expression, len: Expression, child: Expression) extends Run
since = "1.5.0")
// scalastyle:on line.size.limit
case class Length(child: Expression)
extends UnaryExpression with ImplicitCastInputTypes with NullIntolerant{
extends UnaryExpression with ImplicitCastInputTypes with NullIntolerant {
override def dataType: DataType = IntegerType
override def inputTypes: Seq[AbstractDataType] = Seq(TypeCollection(StringType, BinaryType))

Expand Down Expand Up @@ -2002,7 +2002,7 @@ case class Base64(child: Expression)
""",
since = "1.5.0")
case class UnBase64(child: Expression)
extends UnaryExpression with ImplicitCastInputTypes with NullIntolerant{
extends UnaryExpression with ImplicitCastInputTypes with NullIntolerant {

override def dataType: DataType = BinaryType
override def inputTypes: Seq[DataType] = Seq(StringType)
Expand Down