Skip to content

[SPARK-31756][WEBUI] Add real headless browser support for UI test #28627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sarutak wants to merge 10 commits into from
Closed

[SPARK-31756][WEBUI] Add real headless browser support for UI test #28627

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
424092a
Add RealBrowserUISeleniumSuite.scala
sarutak May 19, 2020
4fe3e80
Add ChromeUITest.java
sarutak May 19, 2020
760eb0a
Add ChromeUISeeniumSuite.scala
sarutak May 19, 2020
c2f6a6d
Remove JavaScript related tests from UISeleniumSuite.scala
sarutak May 19, 2020
e701dc9
Disable tests taged as 'ChromeUITest' when tests are run through run-…
sarutak May 19, 2020
6ccbc39
Fixed RealBrowserUISeleniumSuite.
sarutak May 20, 2020
7e49348
Merge branch 'real-headless-browser-support' into real-headless-brows…
sarutak May 24, 2020
6b47fe8
Disabled newly added suite by default.
sarutak May 24, 2020
70d07a3
Introduced test.default.exclude.tags to set excluded tests by default.
sarutak May 25, 2020
2e805ec
Merge branch 'master' of https://github.com/apache/spark into real-he…
sarutak May 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Disable tests taged as 'ChromeUITest' when tests are run through run-… 
…tests.py
  • Loading branch information
@sarutak
sarutak committed May 19, 2020
commit e701dc99048e63a4a8472d16eb70b2a41223ca45
5 changes: 5 additions & 0 deletions dev/run-tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,9 @@
from sparktestsupport.toposort import toposort_flatten
import sparktestsupport.modules as modules

always_excluded_tags = [
Copy link
Member

@dongjoon-hyun dongjoon-hyun May 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

always_excluded_tags might be misleading because this should be tested in the proper environments.

"org.apache.spark.tags.ChromeUITest"
]

# -------------------------------------------------------------------------------------------------
# Functions for traversing module dependency graph
Expand Down Expand Up @@ -606,6 +609,8 @@ def main():
print("[info] Found the following changed modules:",
", ".join(x.name for x in changed_modules))

excluded_tags.extend(always_excluded_tags)

# setup environment variables
# note - the 'root' module doesn't collect environment variables for all modules. Because the
# environment variables should not be set if a module is not changed, even if running the 'root'
Expand Down
2 changes: 2 additions & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,6 +243,7 @@
things breaking.
-->
<spark.test.home>${session.executionRootDirectory}</spark.test.home>
<spark.test.webdriver.chrome.driver></spark.test.webdriver.chrome.driver>

<CodeCacheSize>1g</CodeCacheSize>
</properties>
Expand Down Expand Up @@ -2512,6 +2513,7 @@
<spark.ui.enabled>false</spark.ui.enabled>
<spark.ui.showConsoleProgress>false</spark.ui.showConsoleProgress>
<spark.unsafe.exceptionOnMemoryLeak>true</spark.unsafe.exceptionOnMemoryLeak>
<spark.test.webdriver.chrome.driver>${spark.test.webdriver.chrome.driver}</spark.test.webdriver.chrome.driver>
<!-- Needed by sql/hive tests. -->
<test.src.tables>__not_used__</test.src.tables>
</systemProperties>
Expand Down