Skip to content

[SPARK-31860][BUILD][2.4] only push release tags on success #28667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
holdenk wants to merge 5 commits into from
Closed

[SPARK-31860][BUILD][2.4] only push release tags on success #28667

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
826e3a4
Change build to only push tags on success
holdenk May 28, 2020
afa5d90
Don't delete the checkout we just did in the previous step
holdenk May 28, 2020
d26c735
Don't tell people to wait for a tag that won't show up :p
holdenk May 28, 2020
9bd1dca
Fix the is_dry_run logic (although I'm suspcious of our dry_run suppo…
holdenk Jun 1, 2020
dd9e4a4
Fix the relase tag dry run spark dir rename
holdenk Jun 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Don't tell people to wait for a tag that won't show up :p
  • Loading branch information
@holdenk
holdenk committed May 28, 2020
commit d26c7353e01442459f0c9d17dd013d0f61f2ad02
3 changes: 0 additions & 3 deletions dev/create-release/do-release.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,6 @@ function should_build {
if should_build "tag" && [ $SKIP_TAG = 0 ]; then
run_silent "Creating release tag $RELEASE_TAG..." "tag.log" \
"$SELF/release-tag.sh"
echo "It may take some time for the tag to be synchronized to github."
echo "Press enter when you've verified that the new tag ($RELEASE_TAG) is available."
read
else
echo "Skipping tag creation for $RELEASE_TAG."
fi
Expand Down