Skip to content

[SPARK-31885][SQL] Fix filter push down for old millis timestamps to Parquet #28693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MaxGekk wants to merge 3 commits into from
Closed

[SPARK-31885][SQL] Fix filter push down for old millis timestamps to Parquet #28693

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
13b88ba
Update test to check old timestamps
MaxGekk Jun 1, 2020
f43772c
Allow writing old timestamp w/o exceptions
MaxGekk Jun 1, 2020
c041ff7
Fix ParquetFilters
MaxGekk Jun 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Update test to check old timestamps
  • Loading branch information
@MaxGekk
MaxGekk committed Jun 1, 2020
commit 13b88ba00155ebb5919c599e96924ac0aa1ef78a
16 changes: 9 additions & 7 deletions ...rc/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -589,19 +589,21 @@ abstract class ParquetFilterSuite extends QueryTest with ParquetTest with Shared

test("filter pushdown - timestamp") {
// spark.sql.parquet.outputTimestampType = TIMESTAMP_MILLIS
val millisData = Seq(Timestamp.valueOf("2018-06-14 08:28:53.123"),
Timestamp.valueOf("2018-06-15 08:28:53.123"),
Timestamp.valueOf("2018-06-16 08:28:53.123"),
Timestamp.valueOf("2018-06-17 08:28:53.123"))
val millisData = Seq(
Timestamp.valueOf("1000-06-14 08:28:53.123"),
Timestamp.valueOf("1582-06-15 08:28:53.001"),
Timestamp.valueOf("1900-06-16 08:28:53.0"),
Timestamp.valueOf("2018-06-17 08:28:53.999"))
withSQLConf(SQLConf.PARQUET_OUTPUT_TIMESTAMP_TYPE.key ->
ParquetOutputTimestampType.TIMESTAMP_MILLIS.toString) {
testTimestampPushdown(millisData)
}

// spark.sql.parquet.outputTimestampType = TIMESTAMP_MICROS
val microsData = Seq(Timestamp.valueOf("2018-06-14 08:28:53.123456"),
Timestamp.valueOf("2018-06-15 08:28:53.123456"),
Timestamp.valueOf("2018-06-16 08:28:53.123456"),
val microsData = Seq(
Timestamp.valueOf("1000-06-14 08:28:53.123456"),
Timestamp.valueOf("1582-06-15 08:28:53.123456"),
Timestamp.valueOf("1900-06-16 08:28:53.123456"),
Timestamp.valueOf("2018-06-17 08:28:53.123456"))
withSQLConf(SQLConf.PARQUET_OUTPUT_TIMESTAMP_TYPE.key ->
ParquetOutputTimestampType.TIMESTAMP_MICROS.toString) {
Expand Down