Skip to content

[SPARK-31910][SQL] Enable Java 8 time API in Thrift server #28729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MaxGekk wants to merge 10 commits into from
Closed

[SPARK-31910][SQL] Enable Java 8 time API in Thrift server #28729

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
19c6a51
Enable Java 8 time API in thrift server
MaxGekk Feb 12, 2020
930c293
Set Java 8 Api in SparkOperation
MaxGekk Jun 4, 2020
51a3777
Revert "Set Java 8 Api in SparkOperation"
MaxGekk Jun 4, 2020
6f132a3
Revert "Enable Java 8 time API in thrift server"
MaxGekk Jun 4, 2020
252219f
Add test
MaxGekk Jun 4, 2020
34f7db3
Set Java 8 Api in SparkSQLSessionManager
MaxGekk Jun 4, 2020
76b4ccd
Fix test
MaxGekk Jun 4, 2020
3c35cf5
Enable Java 8 time API in thrift server
MaxGekk Feb 12, 2020
d130f23
Merge remote-tracking branch 'remotes/origin/master' into enable-java…
MaxGekk Jun 5, 2020
f3e5357
Add a test to CliSuite
MaxGekk Jun 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...e-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkOperation.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ private[hive] trait SparkOperation extends Operation with Logging {
sqlContext.sparkContext.setLocalProperty(SparkContext.SPARK_SCHEDULER_POOL, pool)
case None =>
}

sqlContext.sparkContext.setLocalProperty(SQLConf.DATETIME_JAVA8API_ENABLED.key, "true")
Copy link
Contributor

@juliuszsompolski juliuszsompolski Jun 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to be set in sqlContext.sparkSession.conf, not as sqlContext.sparkContext.setLocalProperty.
...
actually, an even better place to set it would be here in openSession, to just set it once per session. https://github.com/apache/spark/blob/master/sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLSessionManager.scala#L65

Copy link
Contributor

@cloud-fan cloud-fan Jun 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall we forbid users setting the java 8 time config back?

// run the body
f
} finally {
Expand Down
3 changes: 3 additions & 0 deletions ...hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLEnv.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import org.apache.spark.{SparkConf, SparkContext}
import org.apache.spark.internal.Logging
import org.apache.spark.sql.{SparkSession, SQLContext}
import org.apache.spark.sql.hive.{HiveExternalCatalog, HiveUtils}
import org.apache.spark.sql.internal.SQLConf
import org.apache.spark.util.Utils

/** A singleton object for the master program. The slaves should not access this. */
Expand All @@ -45,6 +46,8 @@ private[hive] object SparkSQLEnv extends Logging {

sparkConf
.setAppName(maybeAppName.getOrElse(s"SparkSQL::${Utils.localHostName()}"))
.set(SQLConf.DATETIME_JAVA8API_ENABLED, true)


val sparkSession = SparkSession.builder.config(sparkConf).enableHiveSupport().getOrCreate()
sparkContext = sparkSession.sparkContext
Expand Down