[MINOR][SS][DOCS] fileNameOnly parameter description re-unite #28739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaborgsomogyi
commented
Jun 5, 2020
| "s3n://a/b/dataset.txt"<br/> | ||
| "s3a://a/b/c/dataset.txt"<br/> | ||
| "s3a://a/b/c/dataset.txt" | ||
| <br/> |
Contributor
Author
There was a problem hiding this comment.
Moving line break is an addition but I wanted to highlight it. Presume that was the reason of the split.
Contributor
Author
|
With the change the doc looks like this: |
Contributor
Author
Member
|
add to whitelist |
HyukjinKwon
approved these changes
Jun 5, 2020
|
Test build #123569 has finished for PR 28739 at commit
|
|
Test build #123570 has finished for PR 28739 at commit
|
Member
|
Merged to master and branch-3.0. |
HyukjinKwon
pushed a commit
that referenced
this pull request
Jun 6, 2020
### What changes were proposed in this pull request? `fileNameOnly` parameter is split to 2 pieces in [this](dbb8143) commit. This PR re-unites it. ### Why are the changes needed? Parameter description split in doc. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? ``` cd docs/ SKIP_API=1 jekyll build ``` Manual webpage check. Closes #28739 from gaborgsomogyi/datasettxtfix. Authored-by: Gabor Somogyi <[email protected]> Signed-off-by: HyukjinKwon <[email protected]> (cherry picked from commit 04f66bf) Signed-off-by: HyukjinKwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
fileNameOnlyparameter is split to 2 pieces in this commit. This PR re-unites it.Why are the changes needed?
Parameter description split in doc.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manual webpage check.