[SPARK-31980][SQL][2.4] Function sequence() fails if start and end of range are equal dates #28877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hi @dongjoon-hyun |
Member
|
Is this not follow-up but backport, right? |
Member
|
ok to test |
maropu
changed the title
maropu
changed the title
Contributor
Author
Yes, it is a backport. |
|
Test build #124318 has finished for PR 28877 at commit
|
dongjoon-hyun
approved these changes
Jun 20, 2020
dongjoon-hyun
pushed a commit
that referenced
this pull request
Jun 20, 2020
… range are equal dates ### What changes were proposed in this pull request? 1. Add judge equal as bigger condition in `org.apache.spark.sql.catalyst.expressions.Sequence.TemporalSequenceImpl#eval` 2. Unit test for interval `day`, `month`, `year` Former PR to master is [https://github.com/apache/spark/pull/28819](url) Current PR change `stringToInterval => CalendarInterval.fromString` in order to compatible with branch-2.4 ### Why are the changes needed? Bug exists when sequence input get same equal start and end dates, which will occur `while loop` forever ### Does this PR introduce _any_ user-facing change? Yes, Before this PR, people will get a `java.lang.ArrayIndexOutOfBoundsException`, when eval as below: `sql("select sequence(cast('2011-03-01' as date), cast('2011-03-01' as date), interval 1 year)").show(false) ` ### How was this patch tested? Unit test. Closes #28877 from TJX2014/branch-2.4-SPARK-31980-compatible. Authored-by: TJX2014 <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
org.apache.spark.sql.catalyst.expressions.Sequence.TemporalSequenceImpl#evalday,month,yearFormer PR to master is https://github.com/apache/spark/pull/28819
Current PR change
stringToInterval => CalendarInterval.fromStringin order to compatible with branch-2.4Why are the changes needed?
Bug exists when sequence input get same equal start and end dates, which will occur
while loopforeverDoes this PR introduce any user-facing change?
Yes,
Before this PR, people will get a
java.lang.ArrayIndexOutOfBoundsException, when eval as below:sql("select sequence(cast('2011-03-01' as date), cast('2011-03-01' as date), interval 1 year)").show(false)How was this patch tested?
Unit test.