-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-32072][CORE][TESTS] Fix table formatting with benchmark results #28906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #124415 has finished for PR 28906 at commit
|
|
@srowen @dongjoon-hyun Please, review this PR. |
|
Test build #124428 has finished for PR 28906 at commit
|
|
jenkins, retest this, please |
|
Test build #124429 has finished for PR 28906 at commit
|
|
jenkins, retest this, please |
|
Test build #124432 has finished for PR 28906 at commit
|
| prepare make_date() 2951 3182 355 33.9 29.5 1.0X | ||
| make_date(2019, 9, 16) 2325 2415 101 43.0 23.2 1.3X | ||
| make_date(*, *, *) 4556 4573 17 21.9 45.6 0.6X | ||
| prepare make_date() 3309 3429 110 30.2 33.1 1.0X |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The formatting changes are positive of course. Most of the numbers didn't change much at all; these kinda of did, some much more than a few stdevs. Just checking, it was on the same hardware as in the heading?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so, as the head is written by the benchmark framework automatically.
|
thanks, merging to master! |
What changes were proposed in this pull request?
Set column width w/ benchmark names to maximum of either
Why are the changes needed?
To improve readability of benchmark results. For example,
MakeDateTimeBenchmark.Before:
After:
Does this PR introduce any user-facing change?
No
How was this patch tested?
By re-generating benchmark results for
MakeDateTimeBenchmark:in the environment: