-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-32088][PYTHON] Pin the timezone in timestamp_seconds doctest #28932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-32088][PYTHON] Pin the timezone in timestamp_seconds doctest #28932
Conversation
update masterbranch
|
ok to test |
|
@GuoPhilipse, can you elaborate a bit more in the PR description about why it fails with which output? |
sure, will improve it. |
|
Test build #124543 has finished for PR 28932 at commit
|
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM. Thank you, @GuoPhilipse and @HyukjinKwon !
Merged to master.
|
Actually, the SQL config |
What changes were proposed in this pull request?
Add American timezone during timestamp_seconds doctest
Why are the changes needed?
timestamp_secondsdoctest infunctions.pyused default timezone to get expected resultFor example:
But when we have a non-american timezone, the test case will get different test result.
For example, when we set current timezone as
Asia/Shanghai, the test result will beSo no matter where we run the test case ,we will always get the expected permanent result if we set the timezone on one specific area.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Unit test