Skip to content

[SPARK-32192][SQL] Print column name when throws ClassCastException #29010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
StefanXiepj wants to merge 4 commits into from
Closed

[SPARK-32192][SQL] Print column name when throws ClassCastException #29010

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
60199ec
[SPARK-32192][SQL] Print column name when throws ClassCastException
Jul 6, 2020
a535b4d
fix import style
Jul 6, 2020
3e51930
remove the unnecessary change & replace Try-match with try-catch
Jul 7, 2020
018c981
remove unnecessary import
Jul 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions sql/hive/src/main/scala/org/apache/spark/sql/hive/TableReader.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ package org.apache.spark.sql.hive
import java.util.Properties

import scala.collection.JavaConverters._
import scala.util.{Failure, Success, Try}
Copy link
Member

@dongjoon-hyun dongjoon-hyun Jul 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we remove this, @StefanXiepj ?

Copy link
Author

@StefanXiepj StefanXiepj Jul 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your review, i have removed it.


import org.apache.hadoop.conf.Configuration
import org.apache.hadoop.fs.{Path, PathFilter}
Expand Down Expand Up @@ -486,13 +487,19 @@ private[hive] object HadoopTableReader extends HiveInspectors with Logging {
var i = 0
val length = fieldRefs.length
while (i < length) {
val fieldValue = soi.getStructFieldData(raw, fieldRefs(i))
if (fieldValue == null) {
mutableRow.setNullAt(fieldOrdinals(i))
} else {
unwrappers(i)(fieldValue, mutableRow, fieldOrdinals(i))
try {
val fieldValue = soi.getStructFieldData(raw, fieldRefs(i))
if (fieldValue == null) {
mutableRow.setNullAt(fieldOrdinals(i))
} else {
unwrappers(i)(fieldValue, mutableRow, fieldOrdinals(i))
}
i += 1
} catch {
case ex: Throwable =>
logError(s"Exception thrown in field <${fieldRefs(i).getFieldName}>")
throw ex
}
i += 1
}

mutableRow: InternalRow
Expand Down