Skip to content

[SPARK-32196][SQL] Extract In convertible part if it is not convertible #29013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ulysses-you wants to merge 6 commits into from
Closed

[SPARK-32196][SQL] Extract In convertible part if it is not convertible #29013

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6594601
init
ulysses-you Jul 6, 2020
bbf63c9
up ut name
ulysses-you Jul 6, 2020
0d982d2
fix
ulysses-you Jul 7, 2020
f45d6c3
fix or
ulysses-you Jul 7, 2020
9bf23cc
fix comment
ulysses-you Jul 8, 2020
21c5262
add conf
ulysses-you Jul 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix or
  • Loading branch information
@ulysses-you
ulysses-you committed Jul 7, 2020
commit f45d6c31f8d4b840e212dd0561d97ba96e13b458
2 changes: 1 addition & 1 deletion sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ object OptimizeIn extends Rule[LogicalPlan] {
optimizeIn(expr, v, list)
} else if (convertible.nonEmpty && nonConvertible.nonEmpty) {
val optimizedIn = optimizeIn(In(v, convertible), v, convertible)
And(optimizedIn, In(v, nonConvertible))
Or(optimizedIn, In(v, nonConvertible))
} else {
expr
}
Expand Down
2 changes: 1 addition & 1 deletion sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/OptimizeInSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ class OptimizeInSuite extends PlanTest {
val correctAnswer1 =
testRelation
.where(
And(EqualTo(UnresolvedAttribute("a"), Literal(1)),
Or(EqualTo(UnresolvedAttribute("a"), Literal(1)),
In(UnresolvedAttribute("a"), Seq(UnresolvedAttribute("b"))))
)
.analyze
Expand Down