Skip to content

Conversation

@dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Jul 26, 2020

What changes were proposed in this pull request?

This PR aims to recover GitHub Action SparkR tests by pinning Apache Arrow to 0.17.1.

Why are the changes needed?

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass the GitHub Action.

@dongjoon-hyun dongjoon-hyun reopened this Jul 26, 2020
@dongjoon-hyun dongjoon-hyun changed the title fix [SPARK-32451][R][TESTS] Fix GitHub Action SparkR test by pinning Apache Arrow to 0.17.1 Jul 26, 2020
@dongjoon-hyun dongjoon-hyun changed the title [SPARK-32451][R][TESTS] Fix GitHub Action SparkR test by pinning Apache Arrow to 0.17.1 [SPARK-32451][R][TESTS] Pin Apache Arrow to 0.17.1 in GitHubAction/AppVeyor SparkR tests Jul 26, 2020
@dongjoon-hyun
Copy link
Member Author

cc @HyukjinKwon . This is an alternative to pin Apache Arrow version.

# This environment variable works around to test SparkR against a higher version.
R_REMOTES_NO_ERRORS_FROM_WARNINGS: true
# AppVeyor doesn't have python3 yet
PYSPARK_PYTHON: python
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I piggy-backed this because I want to make AppVeyor success in this PR.

dongjoon-hyun added a commit that referenced this pull request Jul 27, 2020
### What changes were proposed in this pull request?

Currently, `GitHub Action` is broken due to `SparkR UT failure` from new Apache Arrow 1.0.0.

![Screen Shot 2020-07-26 at 5 12 08 PM](https://user-images.githubusercontent.com/9700541/88492923-3409f080-cf63-11ea-8fea-6051298c2dd0.png)

This PR aims to update R code according to Apache Arrow 1.0.0 recommendation to pass R unit tests.

An alternative is pinning Apache Arrow version at 0.17.1 and I also created a PR to compare with this.
- #29251

### Why are the changes needed?

- Apache Spark 3.1 supports Apache Arrow 0.15.1+.
- Apache Arrow released 1.0.0 a few days ago and this causes GitHub Action SparkR test failures due to warnings.
    - https://github.com/apache/spark/commits/master

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

- [x] Pass the Jenkins (#29252 (comment))
- [x] Pass the GitHub (https://github.com/apache/spark/runs/912656867)

Closes #29252 from dongjoon-hyun/SPARK-ARROW.

Authored-by: Dongjoon Hyun <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
@dongjoon-hyun
Copy link
Member Author

This is closed in favor of #29252

@dongjoon-hyun dongjoon-hyun deleted the SPARK-ARROW-PIN branch July 27, 2020 01:53
@SparkQA
Copy link

SparkQA commented Jul 27, 2020

Test build #126591 has finished for PR 29251 at commit cfaa6e0.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jul 27, 2020

Test build #126592 has finished for PR 29251 at commit 6a00a75.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jul 27, 2020

Test build #126596 has finished for PR 29251 at commit 395ef0b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants