[SPARK-32525][DOCS] The layout of monitoring.html is broken #29345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
approved these changes
Aug 4, 2020
|
Test build #127031 has finished for PR 29345 at commit
|
dongjoon-hyun
approved these changes
Aug 4, 2020
Member
|
cc @erenavsarogullari and @gengliangwang |
gengliangwang
approved these changes
Aug 4, 2020
Member
gengliangwang
left a comment
gengliangwang
left a comment
There was a problem hiding this comment.
LGTM, thanks for the fix!
Member
|
Merging to master |
Member
|
Thanks folks for the patch and reviews. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR fixes the layout of monitoring.html broken after SPARK-31566(#28354).
The cause is there are 2
<td>tags not closed inmonitoring.md.Why are the changes needed?
This is a bug.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Build docs and the following screenshots are before/after.
Before fixed
After fixed.
Of course, the table is still rendered correctly.
