Skip to content

[SPARK-32585][SQL] Support scala enumeration in ScalaReflection #29403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ulysses-you wants to merge 7 commits into from
Closed

[SPARK-32585][SQL] Support scala enumeration in ScalaReflection #29403

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
556b709
init
ulysses-you Aug 11, 2020
0f98bef
fix ut
ulysses-you Aug 11, 2020
462b0f7
fix
ulysses-you Aug 12, 2020
623a781
null
ulysses-you Sep 27, 2020
68c163a
ExpressionEncoderSuite
ulysses-you Sep 27, 2020
ed81055
typo
ulysses-you Sep 27, 2020
2d675ca
mirror
ulysses-you Sep 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix ut
  • Loading branch information
@ulysses-you
ulysses-you committed Aug 11, 2020
commit 0f98befac8291feaf86f13ca6912ba0786d0bc23
2 changes: 1 addition & 1 deletion sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/ScalaReflectionSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,7 +447,7 @@ class ScalaReflectionSuite extends SparkFunSuite {
}

test("SPARK-32585: Support scala enumeration in ScalaReflection") {
Copy link
Contributor

@marmbrus marmbrus Sep 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would consider putting a test case in ExpressionEncoderSuite as well as I think that checks various combinations of evaluation.

Copy link
Contributor Author

@ulysses-you ulysses-you Sep 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, not realized this test.

assert(schemaFor[FooClassWithEnum].dataType == StringType)
assert(schemaFor[FooClassWithEnum] == Schema(StringType, false))
assert(serializerFor[FooClassWithEnum].dataType == StructType(Seq(
StructField("i", IntegerType, false),
StructField("e", StringType, false))))
Expand Down