Skip to content

[SPARK-32645][INFRA] Upload unit-tests.log as an artifact #29454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HyukjinKwon wants to merge 3 commits into from
Closed

[SPARK-32645][INFRA] Upload unit-tests.log as an artifact #29454

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
adf2e38
Upload unit-tests.log as an artifact
HyukjinKwon Aug 18, 2020
795e272
Make one test failed
HyukjinKwon Aug 18, 2020
d787cd1
Revert "Make one test failed"
HyukjinKwon Aug 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/build_and_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,12 @@ jobs:
with:
name: test-results-${{ matrix.modules }}-${{ matrix.comment }}-${{ matrix.java }}-${{ matrix.hadoop }}-${{ matrix.hive }}
path: "**/target/test-reports/*.xml"
- name: Upload unit tests log files
if: failure()
uses: actions/upload-artifact@v2
with:
name: unit-tests-log-${{ matrix.modules }}-${{ matrix.comment }}-${{ matrix.java }}-${{ matrix.hadoop }}-${{ matrix.hive }}
Copy link
Member

@maropu maropu Aug 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit though, adding a prefix jdk for matrix.java will make the log name clearer just like hadoop3.2 and hive2.3?

Copy link
Member Author

@HyukjinKwon HyukjinKwon Aug 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup. I plan to have a proper name instead of combination of the matrix to address such issue clearly. I'll make a separate PR to address the issue of all such names in this whole file later.

path: "**/target/unit-tests.log"

# Static analysis, and documentation build
lint:
Expand Down