[MINOR][INFRA] Rename master.yml to build_and_test.yml #29459
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @dongjoon-hyun, @gengliangwang and @viirya, this is a very minor stuff. I am preparing to backport GitHub Actions for SPARK-32249 and thought it's less readable. WDYT? |
Member
|
+1. No problem. |
dongjoon-hyun
approved these changes
Aug 18, 2020
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
(Pending GitHub Action)
|
Test build #127529 has finished for PR 29459 at commit
|
Member
Author
|
Thanks guys. Let me merge this after I cherry-pick Github Actions to other branches (at #29460) |
Member
|
@HyukjinKwon shall we merge this one to unblock #29460 and #29454 ? |
Member
Author
|
Yup, let's do that. Thanks @gengliangwang. |
Member
|
Thanks, merging to master |
Member
Author
|
Thanks @gengliangwang! |
HyukjinKwon
added a commit
to HyukjinKwon/spark
that referenced
this pull request
Aug 19, 2020
### What changes were proposed in this pull request? This PR renames `master.yml` to `build_and_test.yml` to indicate this is the workflow that builds and runs the tests. ### Why are the changes needed? Just for readability. `master.yml` looks like the name of the branch (to me). ### Does this PR introduce _any_ user-facing change? No, dev-only. ### How was this patch tested? GitHub Actions build in this PR will test it out. Closes apache#29459 from HyukjinKwon/minor-rename. Authored-by: HyukjinKwon <[email protected]> Signed-off-by: Gengliang Wang <[email protected]>
HyukjinKwon
added a commit
to HyukjinKwon/spark
that referenced
this pull request
Aug 19, 2020
### What changes were proposed in this pull request? This PR renames `master.yml` to `build_and_test.yml` to indicate this is the workflow that builds and runs the tests. ### Why are the changes needed? Just for readability. `master.yml` looks like the name of the branch (to me). ### Does this PR introduce _any_ user-facing change? No, dev-only. ### How was this patch tested? GitHub Actions build in this PR will test it out. Closes apache#29459 from HyukjinKwon/minor-rename. Authored-by: HyukjinKwon <[email protected]> Signed-off-by: Gengliang Wang <[email protected]>
HyukjinKwon
added a commit
to HyukjinKwon/spark
that referenced
this pull request
Aug 19, 2020
### What changes were proposed in this pull request? This PR renames `master.yml` to `build_and_test.yml` to indicate this is the workflow that builds and runs the tests. ### Why are the changes needed? Just for readability. `master.yml` looks like the name of the branch (to me). ### Does this PR introduce _any_ user-facing change? No, dev-only. ### How was this patch tested? GitHub Actions build in this PR will test it out. Closes apache#29459 from HyukjinKwon/minor-rename. Authored-by: HyukjinKwon <[email protected]> Signed-off-by: Gengliang Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR renames
master.ymltobuild_and_test.ymlto indicate this is the workflow that builds and runs the tests.Why are the changes needed?
Just for readability.
master.ymllooks like the name of the branch (to me).Does this PR introduce any user-facing change?
No, dev-only.
How was this patch tested?
GitHub Actions build in this PR will test it out.