[SPARK-32451][R][3.0] Support Apache Arrow 1.0.0 #29462
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @zhengruifeng FYI. |
|
Test build #127556 has finished for PR 29462 at commit
|
viirya
approved these changes
Aug 18, 2020
Member
viirya
left a comment
viirya
left a comment
There was a problem hiding this comment.
Oh, we didn't port back Arrow 1.0 support in previous PR. LGTM.
dongjoon-hyun
approved these changes
Aug 19, 2020
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thanks, @HyukjinKwon and @viirya .
Merged to branch-3.0.
dongjoon-hyun
pushed a commit
that referenced
this pull request
Aug 19, 2020
### What changes were proposed in this pull request? This PR ports back #29252 to support Arrow 1.0.0. Currently, SparkR with Arrow tests fails with the latest Arrow version in branch-3.0, see https://github.com/apache/spark/pull/29460/checks?check_run_id=996972267 ### Why are the changes needed? To support higher Arrow R version with SparkR. ### Does this PR introduce _any_ user-facing change? Yes, users will be able to use SparkR with Arrow 1.0.0+. ### How was this patch tested? Manually tested, GitHub Actions will test it. Closes #29462 from HyukjinKwon/SPARK-32451-3.0. Authored-by: HyukjinKwon <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Member
Author
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR ports back #29252 to support Arrow 1.0.0.
Currently, SparkR with Arrow tests fails with the latest Arrow version in branch-3.0, see https://github.com/apache/spark/pull/29460/checks?check_run_id=996972267
Why are the changes needed?
To support higher Arrow R version with SparkR.
Does this PR introduce any user-facing change?
Yes, users will be able to use SparkR with Arrow 1.0.0+.
How was this patch tested?
Manually tested, GitHub Actions will test it.