Skip to content

[SPARK-32721][SQL] Simplify if clauses with null and boolean #29567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sunchao wants to merge 7 commits into from
Closed

[SPARK-32721][SQL] Simplify if clauses with null and boolean #29567

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f9e87f0
SPARK-32721
sunchao Aug 28, 2020
e4d929c
Fix bugs and merge into SimplifyConditionals
sunchao Aug 28, 2020
bb7c38c
Fix lint
sunchao Aug 28, 2020
cc66198
Fix test failure
sunchao Aug 28, 2020
60e0e92
Address comments
sunchao Aug 30, 2020
2b90c19
Test if evaluation with nullable condition
sunchao Aug 31, 2020
71bd033
Fix indentation
sunchao Aug 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix lint
  • Loading branch information
@sunchao
sunchao committed Aug 28, 2020
commit bb7c38cdd5f139a7cbcf04de6ed59d8fd0313bd4
2 changes: 2 additions & 0 deletions sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ package org.apache.spark.sql.catalyst.optimizer

import scala.collection.immutable.HashSet
import scala.collection.mutable.{ArrayBuffer, Stack}

import org.apache.spark.sql.catalyst.analysis._
import org.apache.spark.sql.catalyst.expressions._
import org.apache.spark.sql.catalyst.expressions.Literal.{FalseLiteral, TrueLiteral}
Expand Down Expand Up @@ -717,6 +718,7 @@ object SimplifyCasts extends Rule[LogicalPlan] {
}
}


/**
* Removes nodes that are not necessary.
*/
Expand Down