-
Notifications
You must be signed in to change notification settings - Fork 29k
Clean up and simplify Spark configuration #299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
ac2d65e
Change spark.local.dir -> SPARK_LOCAL_DIRS
pwendell 0faa3b6
Stash of adding config options in submit script and YARN
pwendell 6eaf7d0
executorJavaOpts
pwendell 4982331
Remove SPARK_LIBRARY_PATH
pwendell 1f75238
SPARK_JAVA_OPTS --> SPARK_MASTER_OPTS for master settings
pwendell 84cc5e5
Small clean-up
pwendell 5b0ba8e
Don't ship executor envs
pwendell 7cc70e4
Clean up terminology inside of spark-env script
pwendell 761ebcd
Library path and classpath for drivers
pwendell 437aed1
Small fix
pwendell 46555c1
Review feedback and import clean-ups
pwendell b72d183
Review feedback for spark env file
pwendell ace4ead
Responses to review feedback.
pwendell b08893b
Additional improvements.
pwendell afc9ed8
Cleaning up line limits and two compile errors.
pwendell 4ee6f9d
Making YARN doc changes consistent
pwendell c2a2909
Test compile fixes
pwendell be42f35
Handle case where SPARK_HOME is not set
pwendell e83cd8f
Changes to allow re-use of test applications
pwendell 308f1f6
Properly escape quotes and other clean-up for YARN
pwendell fda0301
Note
pwendell ffa00fe
Review feedback
pwendell a762901
Fixing test failures
pwendell d50c388
Merge remote-tracking branch 'apache/master' into config-cleanup
pwendell a56b125
Responses to Tom's review
pwendell af0adf7
Automatically add user jar
pwendell b16e6a2
Cleanup of spark-submit script and Scala quick start guide
pwendell af09e3e
Mention config file in docs and clean-up docs
pwendell 0086939
Minor style fixes
pwendell b4b496c
spark-defaults.properties -> spark-defaults.conf
pwendell a006464
Moving properties file template.
pwendell 127f301
Improvements to testing
pwendell File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
Change spark.local.dir -> SPARK_LOCAL_DIRS
- Loading branch information
commit ac2d65e9299109759ee9b46687acee2cac5b276c
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pwendell
If we're running on local mode, then SparkEnv will have already been created and DiskBlockManager will have already created the local dirs using the previous value of "spark.local.dir". When we change "spark.local.dir" here, the local Executor will attempt to use local directories that might not exist, causing problems for local jobs that use addFIle().
I discovered this issue when debugging some spark-perf tests in local mode on an EC2 node.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe the problem here lies with spark-ec2's default configuration setting SPARK_LOCAL_DIRS on the master when it should only really be used on workers, and in not setting
spark.local.dir.I think the current documentation for SPARK_LOCAL_DIRS sort of suggests that it acts as an override, without any caveats about whether it only should be used on workers, etc.