[FIX] disable benchmark code #2990
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
LGTM. This patch decreases build time by roughly 10 minutes. Good job! |
|
Test build #22424 has started for PR 2990 at commit
|
|
Test build #22424 has finished for PR 2990 at commit
|
|
Test FAILed. |
Contributor
Author
|
The failed test from streaming is a known flaky test. @tdas I've merged this one into master (because it will speed up Jenkins builds). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot to disable the benchmark code in #2937, which increased the Jenkins build time by couple minutes.
@aarondav