-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-4145] Web UI job pages #3009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
2568a6c
Rename JobProgressPage to AllStagesPage:
JoshRosen 4487dcb
[SPARK-4145] Web UI job pages
JoshRosen bfce2b9
Address review comments, except for progress bar.
JoshRosen 4b206fb
Merge remote-tracking branch 'origin/master' into job-page
JoshRosen 45343b8
More comments
JoshRosen a475ea1
Add progress bars to jobs page.
JoshRosen 56701fa
Move last stage name / description logic out of markup.
JoshRosen 1cf4987
Fix broken kill links; add Selenium test to avoid future regressions.
JoshRosen 85e9c85
Extract startTime into separate variable.
JoshRosen 4d58e55
Change label to "Tasks (for all stages)"
JoshRosen 4846ce4
Hide "(Job Group") if no jobs were submitted in job groups.
JoshRosen b7bf30e
Add stages progress bar; fix bug where active stages show as completed.
JoshRosen 8a2351b
Add help tooltip to Spark Jobs page.
JoshRosen 3d0a007
Merge remote-tracking branch 'origin/master' into job-page
JoshRosen 1145c60
Display text instead of progress bar for stages.
JoshRosen d62ea7b
Add failing Selenium test for stage overcounting issue.
JoshRosen 79793cd
Track indices of completed stage to avoid overcounting when failures …
JoshRosen 5884f91
Add StageInfos to SparkListenerJobStart event.
JoshRosen 8ab6c28
Compute numTasks from job start stage infos.
JoshRosen 8955f4c
Display information for pending stages on jobs page.
JoshRosen e2f2c43
Fix sorting of stages in job details page.
JoshRosen 171b53c
Move `startTime` to the start of SparkContext.
JoshRosen f2a15da
Add status field to job details page.
JoshRosen 5eb39dc
Add pending stages table to job page.
JoshRosen d69c775
Fix table sorting on all jobs page.
JoshRosen 7d10b97
Merge remote-tracking branch 'apache/master' into job-page
JoshRosen 67080ba
Ensure that "phantom stages" don't cause memory leaks.
JoshRosen eebdc2c
Don’t display pending stages for completed jobs.
JoshRosen 034aa8d
Use `.max()` to find result stage for job.
JoshRosen 0b77e3e
More bug fixes for phantom stages.
JoshRosen 1f45d44
Incorporate a bunch of minor review feedback.
JoshRosen 61c265a
Add “skipped stages” table; only display non-empty tables.
JoshRosen 2bbf41a
Update job progress bar to reflect skipped tasks/stages.
JoshRosen 6f17f3f
Only store StageInfos in SparkListenerJobStart event.
JoshRosen ff804cd
Don't write "Stage Ids" field in JobStartEvent JSON.
JoshRosen b89c258
More JSON protocol backwards-compatibility fixes.
JoshRosen f00c851
Fix JsonProtocol compatibility
JoshRosen eb05e90
Disable kill button in completed stages tables.
JoshRosen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add progress bars to jobs page.
- Loading branch information
commit a475ea15561d30f0b575c0a2f3c06131f73e3818
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So what's the behavior now for resubmitted stages? Will they result in # completed stages > # total stages in the UI (and similarly for # tasks)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I realized what this is (the apparent-hang behavior we discussed) -- but it would be great to add a comment somewhere describing this (maybe in JobUIData, explaining why completedStages is a set?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a comment over in JobUIData. Thanks!