Skip to content

[SPARK-33422][DOC] Fix the correct display of left menu item #30335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
liucht-inspur wants to merge 3 commits into from
Closed

[SPARK-33422][DOC] Fix the correct display of left menu item #30335

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
31996a1
Fix the correct display of left menu item
liucht-inspur Nov 11, 2020
0dff48a
Adjust the code format and add whitespace
liucht-inspur Nov 12, 2020
5dee41d
Fix the display style when the bar is folded #30335 (comment)
liucht-inspur Nov 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/css/main.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,6 +325,7 @@ a.anchorjs-link:hover { text-decoration: none; }
border-bottom-width: 0px;
margin-top: 0px;
width: 210px;
Copy link
Member

@HyukjinKwon HyukjinKwon Nov 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're here, shall we batch left-menu.width to 210 px too? That makes the subtitles look truncated. I don't know why we made that longer specifically (https://github.com/apache/spark/pull/25459/files#r521829348).

And, actually we should make the width itself more wider. I would suggest to make it 280px. cc @gatorsmile and @dilipbiswal

Copy link
Contributor Author

@liucht-inspur liucht-inspur Nov 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @HyukjinKwon As I modified, the horizontal scrollbar can be displayed and used after setting the height to 80%
after:
image

Copy link
Member

@srowen srowen Nov 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does that sound @HyukjinKwon

Copy link
Member

@HyukjinKwon HyukjinKwon Nov 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine. Can be separately done. but I think we should still fix #30335 (comment).

Copy link
Contributor Author

@liucht-inspur liucht-inspur Nov 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok，Thanks @HyukjinKwon and @srowen , I will submit the code separately as a fix for the next issues.

height: 80%;
Copy link
Member

@HyukjinKwon HyukjinKwon Nov 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it wouldn't work properly when the side bar is folded:

Before:

Screen Shot 2020-11-12 at 1 24 49 PM

After:

Screen Shot 2020-11-12 at 1 24 53 PM

Copy link
Member

@HyukjinKwon HyukjinKwon Nov 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also the end of bat does not seem matching:
Screen Shot 2020-11-12 at 1 26 30 PM

float: left;
position: fixed;
overflow-y: scroll;
Expand Down