Skip to content

[SPARK-33143][PYTHON] Add configurable timeout to python server and client #30389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gaborgsomogyi wants to merge 14 commits into from
Closed

[SPARK-33143][PYTHON] Add configurable timeout to python server and client #30389

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
09b1235
[SPARK-33143][PYTHON] Add configurable timeout to python server and c…
gaborgsomogyi Nov 16, 2020
17d357b
compile fix
gaborgsomogyi Nov 16, 2020
424be64
PythonRDDSuite fix
gaborgsomogyi Nov 17, 2020
d9feed8
Some cleanup
gaborgsomogyi Nov 17, 2020
6e8e194
Additional trace
gaborgsomogyi Nov 17, 2020
f504af3
Partial review fix
gaborgsomogyi Nov 18, 2020
1595581
Driver side coverage
gaborgsomogyi Nov 19, 2020
a67acd7
Style fix
gaborgsomogyi Nov 20, 2020
0f9e587
Update core/src/test/scala/org/apache/spark/api/python/PythonRDDSuite…
HyukjinKwon Nov 23, 2020
cd2d595
Update core/src/test/scala/org/apache/spark/api/python/PythonRDDSuite…
HyukjinKwon Nov 23, 2020
d9f0a1b
Update core/src/main/scala/org/apache/spark/security/SocketAuthServer…
HyukjinKwon Nov 23, 2020
2913fb1
Update core/src/test/scala/org/apache/spark/api/python/PythonRDDSuite…
HyukjinKwon Nov 23, 2020
ef137b6
Update core/src/test/scala/org/apache/spark/api/python/PythonRDDSuite…
HyukjinKwon Nov 23, 2020
363f3bb
Fix test in PythonRDDSuite
HyukjinKwon Nov 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix test in PythonRDDSuite
  • Loading branch information
@HyukjinKwon
HyukjinKwon committed Nov 23, 2020
commit 363f3bb07ccd34cf3d70303a5512595cc59b603b
2 changes: 1 addition & 1 deletion core/src/main/scala/org/apache/spark/security/SocketAuthHelper.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ import org.apache.spark.util.Utils
*
* There's no secrecy, so this relies on the sockets being either local or somehow encrypted.
*/
private[spark] class SocketAuthHelper(conf: SparkConf) {
private[spark] class SocketAuthHelper(val conf: SparkConf) {

val secret = Utils.createSecret(conf)

Expand Down
2 changes: 1 addition & 1 deletion core/src/main/scala/org/apache/spark/security/SocketAuthServer.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ private[spark] abstract class SocketAuthServer[T](
logTrace("Creating listening socket")
val serverSocket = new ServerSocket(0, 1, InetAddress.getByAddress(Array(127, 0, 0, 1)))
// Close the socket if no connection in the configured seconds
val timeout = SparkEnv.get.conf.get(PYTHON_AUTH_SOCKET_TIMEOUT).toInt
val timeout = authHelper.conf.get(PYTHON_AUTH_SOCKET_TIMEOUT).toInt
Copy link
Member

@HyukjinKwon HyukjinKwon Nov 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, actually the test in PythonRDDSuite was related.

In python server error handling test we don't initialize SparkEnv because we don't create SparkContext or executor there by default, but SparkEnv.get was used in the previous change which ended up with NPE.

Now, I made a change to work around by using SparkConf directly here.

Copy link
Member

@dongjoon-hyun dongjoon-hyun Nov 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it~

logTrace(s"Setting timeout to $timeout sec")
serverSocket.setSoTimeout(timeout * 1000)

Expand Down