Skip to content

[MINOR][SQL] Remove getTables() from r.SQLUtils #30527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MaxGekk wants to merge 3 commits into from
Closed

[MINOR][SQL] Remove getTables() from r.SQLUtils #30527

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bedd63b
Remove `getTables()` from `r.SQLUtils`
MaxGekk Nov 28, 2020
cc3112d
Remove an unused import
MaxGekk Nov 28, 2020
7693c04
Trigger build
MaxGekk Nov 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions sql/core/src/main/scala/org/apache/spark/sql/api/r/SQLUtils.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ import org.apache.spark.sql._
import org.apache.spark.sql.catalyst.expressions.{ExprUtils, GenericRowWithSchema}
import org.apache.spark.sql.catalyst.parser.CatalystSqlParser
import org.apache.spark.sql.execution.arrow.ArrowConverters
import org.apache.spark.sql.execution.command.ShowTablesCommand
import org.apache.spark.sql.internal.StaticSQLConf.CATALOG_IMPLEMENTATION
import org.apache.spark.sql.types._

Expand Down Expand Up @@ -216,15 +215,6 @@ private[sql] object SQLUtils extends Logging {
}
}

def getTables(sparkSession: SparkSession, databaseName: String): DataFrame = {
databaseName match {
case n: String if n != null && n.trim.nonEmpty =>
Dataset.ofRows(sparkSession, ShowTablesCommand(Some(n), None))
case _ =>
Dataset.ofRows(sparkSession, ShowTablesCommand(None, None))
}
}

def getTableNames(sparkSession: SparkSession, databaseName: String): Array[String] = {
val db = databaseName match {
case _ if databaseName != null && databaseName.trim.nonEmpty =>
Expand Down