Skip to content

[SPARK-33685][SQL] Migrate DROP VIEW command to use UnresolvedView to resolve the identifier #30636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
imback82 wants to merge 8 commits into from
Closed

[SPARK-33685][SQL] Migrate DROP VIEW command to use UnresolvedView to resolve the identifier #30636

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4d75250
initial commit -a
imback82 Dec 7, 2020
bc3d861
fix tests
imback82 Dec 7, 2020
c23f61f
fix hive test
imback82 Dec 7, 2020
0ce0942
Address PR comments
imback82 Dec 8, 2020
f8d1da5
Merge remote-tracking branch 'upstream/master' into drop_view_v2
imback82 Dec 8, 2020
addfa13
fix test
imback82 Dec 8, 2020
78da830
fix test
imback82 Dec 8, 2020
8decf27
Address PR comment
imback82 Dec 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix test
  • Loading branch information
@imback82
imback82 committed Dec 8, 2020
commit addfa137684b218347230d4d8110ce97c58ac5a8
12 changes: 7 additions & 5 deletions sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/DDLParserSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -721,16 +721,18 @@ class DDLParserSuite extends AnalysisTest {
}

test("drop view") {
val cmd = "DROP VIEW"
val hint = Some("Please use DROP TABLE instead.")
parseCompare(s"DROP VIEW testcat.db.view",
DropView(UnresolvedView(Seq("testcat", "db", "view"), "DROP VIEW"), ifExists = false))
DropView(UnresolvedView(Seq("testcat", "db", "view"), cmd, hint), ifExists = false))
parseCompare(s"DROP VIEW db.view",
DropView(UnresolvedView(Seq("db", "view"), "DROP VIEW"), ifExists = false))
DropView(UnresolvedView(Seq("db", "view"), cmd, hint), ifExists = false))
parseCompare(s"DROP VIEW IF EXISTS db.view",
DropView(UnresolvedView(Seq("db", "view"), "DROP VIEW"), ifExists = true))
DropView(UnresolvedView(Seq("db", "view"), cmd, hint), ifExists = true))
parseCompare(s"DROP VIEW view",
DropView(UnresolvedView(Seq("view"), "DROP VIEW"), ifExists = false))
DropView(UnresolvedView(Seq("view"), cmd, hint), ifExists = false))
parseCompare(s"DROP VIEW IF EXISTS view",
DropView(UnresolvedView(Seq("view"), "DROP VIEW"), ifExists = true))
DropView(UnresolvedView(Seq("view"), cmd, hint), ifExists = true))
}

private def testCreateOrReplaceDdl(
Expand Down