Skip to content

[SPARK-33757][INFRA][R] Fix the R dependencies build error on GitHub Actions and AppVeyor #30737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sarutak wants to merge 5 commits into from
Closed

[SPARK-33757][INFRA][R] Fix the R dependencies build error on GitHub Actions and AppVeyor #30737

sarutak wants to merge 5 commits into from

Conversation

@sarutak
Copy link
Member

@sarutak sarutak commented Dec 11, 2020 •
edited
Loading

What changes were proposed in this pull request?

This PR fixes the R dependencies build error on GitHub Actions and AppVeyor.
The reason seems that usethis package is updated 2020/12/10.
https://cran.r-project.org/web/packages/usethis/index.html

Why are the changes needed?

To keep the build clean.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Should be done by GitHub Actions.

@sarutak sarutak force-pushed the fix-r-dependencies-build-error branch from 2d436ef to 0feeef9 Compare December 11, 2020 13:39
@github-actions github-actions bot added the INFRA label Dec 11, 2020
@HyukjinKwon
Copy link
Member

HyukjinKwon commented Dec 11, 2020

Nice, thanks @sarutak. Do you mind updating appveyor.yml too?

HyukjinKwon
HyukjinKwon approved these changes Dec 11, 2020
View reviewed changes
Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if tests pass

@sarutak
Copy link
Member Author

sarutak commented Dec 11, 2020

Sure, I'll try it.

@sarutak sarutak changed the title [SPARK-33757][INFRA][R] Fix the R dependencies build error on GitHub Actions [SPARK-33757][INFRA][R] Fix the R dependencies build error on GitHub Actions and AppVeyor Dec 11, 2020
@SparkQA
Copy link

SparkQA commented Dec 11, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37266/

@SparkQA
Copy link

SparkQA commented Dec 11, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37270/

@SparkQA
Copy link

SparkQA commented Dec 11, 2020

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37266/

@SparkQA
Copy link

SparkQA commented Dec 11, 2020

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37270/

@SparkQA
Copy link

SparkQA commented Dec 11, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37274/

HyukjinKwon pushed a commit that referenced this pull request Dec 11, 2020
@sarutak @HyukjinKwon
[SPARK-33757][INFRA][R] Fix the R dependencies build error on GitHub …
4c4aee3 
…Actions and AppVeyor

### What changes were proposed in this pull request?

This PR fixes the R dependencies build error on GitHub Actions and AppVeyor.
The reason seems that `usethis` package is updated 2020/12/10.
https://cran.r-project.org/web/packages/usethis/index.html

### Why are the changes needed?

To keep the build clean.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Should be done by GitHub Actions.

Closes #30737 from sarutak/fix-r-dependencies-build-error.

Authored-by: Kousuke Saruta <[email protected]>
Signed-off-by: HyukjinKwon <[email protected]>
(cherry picked from commit fb2e3af)
Signed-off-by: HyukjinKwon <[email protected]>
HyukjinKwon pushed a commit that referenced this pull request Dec 11, 2020
@sarutak @HyukjinKwon
[SPARK-33757][INFRA][R] Fix the R dependencies build error on GitHub …
2534165 
…Actions and AppVeyor

### What changes were proposed in this pull request?

This PR fixes the R dependencies build error on GitHub Actions and AppVeyor.
The reason seems that `usethis` package is updated 2020/12/10.
https://cran.r-project.org/web/packages/usethis/index.html

### Why are the changes needed?

To keep the build clean.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Should be done by GitHub Actions.

Closes #30737 from sarutak/fix-r-dependencies-build-error.

Authored-by: Kousuke Saruta <[email protected]>
Signed-off-by: HyukjinKwon <[email protected]>
(cherry picked from commit fb2e3af)
Signed-off-by: HyukjinKwon <[email protected]>
@HyukjinKwon
Copy link
Member

HyukjinKwon commented Dec 11, 2020

Merged to master, branch-3.1, branch-3.0 and branch-2.4.

HyukjinKwon pushed a commit that referenced this pull request Dec 11, 2020
@sarutak @HyukjinKwon
[SPARK-33757][INFRA][R] Fix the R dependencies build error on GitHub …
d34bc2a 
…Actions and AppVeyor

### What changes were proposed in this pull request?

This PR fixes the R dependencies build error on GitHub Actions and AppVeyor.
The reason seems that `usethis` package is updated 2020/12/10.
https://cran.r-project.org/web/packages/usethis/index.html

### Why are the changes needed?

To keep the build clean.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Should be done by GitHub Actions.

Closes #30737 from sarutak/fix-r-dependencies-build-error.

Authored-by: Kousuke Saruta <[email protected]>
Signed-off-by: HyukjinKwon <[email protected]>
(cherry picked from commit fb2e3af)
Signed-off-by: HyukjinKwon <[email protected]>
@SparkQA
Copy link

SparkQA commented Dec 11, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37271/

@SparkQA
Copy link

SparkQA commented Dec 11, 2020

Test build #132661 has finished for PR 30737 at commit 0feeef9.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Dec 11, 2020

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37274/

@SparkQA
Copy link

SparkQA commented Dec 11, 2020

Test build #132665 has finished for PR 30737 at commit 1d6ed35.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Dec 11, 2020

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37271/

@SparkQA
Copy link

SparkQA commented Dec 11, 2020

Test build #132667 has finished for PR 30737 at commit ca2f8da.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Dec 11, 2020

Test build #132670 has finished for PR 30737 at commit 9161bd1.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member

dongjoon-hyun commented Dec 11, 2020

Thank you, @sarutak and @HyukjinKwon .

@sarutak sarutak mentioned this pull request Dec 13, 2020
Closed
dongjoon-hyun pushed a commit that referenced this pull request Dec 14, 2020
@sarutak @dongjoon-hyun
[SPARK-33757][INFRA][R][FOLLOWUP] Provide more simple solution
b135db3 
### What changes were proposed in this pull request?

This PR proposes a better solution for the R build failure on GitHub Actions.
The issue is solved in #30737 but I noticed the following two things.

* We can use the latest `usethis` if we install additional libraries on the GitHub Actions environment.
* For tests on AppVeyor, `usethis` is not necessary, so I partially revert the previous change.

### Why are the changes needed?

For more simple solution.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Confirmed on GitHub Actions and AppVeyor on my account.

Closes #30753 from sarutak/followup-SPARK-33757.

Authored-by: Kousuke Saruta <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
dongjoon-hyun pushed a commit that referenced this pull request Dec 14, 2020
@sarutak @dongjoon-hyun
[SPARK-33757][INFRA][R][FOLLOWUP] Provide more simple solution
293c999 
### What changes were proposed in this pull request?

This PR proposes a better solution for the R build failure on GitHub Actions.
The issue is solved in #30737 but I noticed the following two things.

* We can use the latest `usethis` if we install additional libraries on the GitHub Actions environment.
* For tests on AppVeyor, `usethis` is not necessary, so I partially revert the previous change.

### Why are the changes needed?

For more simple solution.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Confirmed on GitHub Actions and AppVeyor on my account.

Closes #30753 from sarutak/followup-SPARK-33757.

Authored-by: Kousuke Saruta <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
(cherry picked from commit b135db3)
Signed-off-by: Dongjoon Hyun <[email protected]>
dongjoon-hyun pushed a commit that referenced this pull request Dec 14, 2020
@sarutak @dongjoon-hyun
[SPARK-33757][INFRA][R][FOLLOWUP] Provide more simple solution
7cd1aab 
### What changes were proposed in this pull request?

This PR proposes a better solution for the R build failure on GitHub Actions.
The issue is solved in #30737 but I noticed the following two things.

* We can use the latest `usethis` if we install additional libraries on the GitHub Actions environment.
* For tests on AppVeyor, `usethis` is not necessary, so I partially revert the previous change.

### Why are the changes needed?

For more simple solution.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Confirmed on GitHub Actions and AppVeyor on my account.

Closes #30753 from sarutak/followup-SPARK-33757.

Authored-by: Kousuke Saruta <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
(cherry picked from commit b135db3)
Signed-off-by: Dongjoon Hyun <[email protected]>
dongjoon-hyun pushed a commit that referenced this pull request Dec 14, 2020
@sarutak @dongjoon-hyun
[SPARK-33757][INFRA][R][FOLLOWUP] Provide more simple solution
88c3649 
### What changes were proposed in this pull request?

This PR proposes a better solution for the R build failure on GitHub Actions.
The issue is solved in #30737 but I noticed the following two things.

* We can use the latest `usethis` if we install additional libraries on the GitHub Actions environment.
* For tests on AppVeyor, `usethis` is not necessary, so I partially revert the previous change.

### Why are the changes needed?

For more simple solution.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Confirmed on GitHub Actions and AppVeyor on my account.

Closes #30753 from sarutak/followup-SPARK-33757.

Authored-by: Kousuke Saruta <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
(cherry picked from commit b135db3)
Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HyukjinKwon HyukjinKwon HyukjinKwon approved these changes

Assignees

No one assigned

Labels

INFRA

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sarutak @HyukjinKwon @SparkQA @dongjoon-hyun