-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-34246][SQL] New type coercion syntax rules in ANSI mode #31349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
gengliangwang
wants to merge
23
commits into
apache:master
from
gengliangwang:ansiImplicitConversion
Closed
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
cef9e31
new ansi implicit cast rules
gengliangwang 3566196
remove non-ascii char
gengliangwang 37722ee
special handling string literal
gengliangwang d135e83
WindowFrameCoercion
gengliangwang f3a5f39
update test outputs
gengliangwang 7d33ffd
revise comments
gengliangwang ab694bd
address maropu's comments
gengliangwang f48973e
update sql test output
gengliangwang 33dd04b
promote string literal in In predicates
gengliangwang 4fabb65
address nit comment
gengliangwang f831cf1
add comments for APIs
gengliangwang ae5caa2
address comments
gengliangwang 6f6bd87
fix compiling
gengliangwang a5058a6
revise rule `PromoteStringLiterals` and add test case
gengliangwang 2590ec5
add test cases
gengliangwang caa9449
implicit cast string literals recursively
gengliangwang bd58d33
fix unit tests
gengliangwang 39048ab
add test cases
gengliangwang b64b926
fix test failure
gengliangwang 025f915
address comments
gengliangwang 1c8a911
update with.sql
gengliangwang 7a57144
fix query outputs
gengliangwang 1f5ecdc
Merge remote-tracking branch 'upstream/master' into ansiImplicitConve…
gengliangwang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix compiling
- Loading branch information
commit 6f6bd87d8ac9f126c93eb73deb8b4e869672ca2f
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we move
findCommonTypeDifferentOnlyInNullFlagsintoobject TypeCoercion?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hasStringTypeis only used forTypeCoercion, too?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, let me move them