-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-34599][SQL]Fix the issue that INSERT INTO OVERWRITE doesn't support partition columns containing dot for DSv2 #31713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -477,5 +477,15 @@ trait InsertIntoSQLOnlyTests | |
| verifyTable(t1, spark.table(view)) | ||
| } | ||
| } | ||
|
|
||
| test("SPARK-34599: InsertInto: overwrite - dot in the partition column name - static mode") { | ||
| import testImplicits._ | ||
| val t1 = "tbl" | ||
| withTable(t1) { | ||
| sql(s"CREATE TABLE $t1 (`a.b` string, `c.d` string) USING $v2Format PARTITIONED BY (`a.b`)") | ||
| sql(s"INSERT OVERWRITE $t1 PARTITION (`a.b` = 'a') (`c.d`) VALUES('b')") | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. does this bug only exist when the INSERT have a column list?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
No. It exists in queries without the column list as well. I made this test using the column list to ensure we don't have the similar issue there. |
||
| verifyTable(t1, Seq("a" -> "b").toDF("id", "data")) | ||
| } | ||
| } | ||
| } | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch!