Skip to content

[SPARK-34605][SQL] Support java.time.Duration as an external type of the day-time interval type #31729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MaxGekk wants to merge 4 commits into from
Closed

[SPARK-34605][SQL] Support java.time.Duration as an external type of the day-time interval type #31729

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b5b021e
Support java.time.Duration as an external type of DayTimeIntervalType
MaxGekk Mar 3, 2021
737a55f
Add tests to IntervalUtilsSuite
MaxGekk Mar 4, 2021
bb0f6cd
Add tests to CatalystTypeConvertersSuite
MaxGekk Mar 4, 2021
b826afd
Add tests to LiteralExpressionSuite
MaxGekk Mar 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add tests to IntervalUtilsSuite
  • Loading branch information
@MaxGekk
MaxGekk committed Mar 4, 2021
commit 737a55f3ff47ab0e0eac4c3dee2b4c5c9c6835eb
22 changes: 22 additions & 0 deletions sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/IntervalUtilsSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@

package org.apache.spark.sql.catalyst.util

import java.time.Duration
import java.util.concurrent.TimeUnit

import org.apache.spark.SparkFunSuite
Expand Down Expand Up @@ -379,4 +380,25 @@ class IntervalUtilsSuite extends SparkFunSuite with SQLHelper {
intercept[ArithmeticException](multiplyExact(maxMonth, 2))
intercept[ArithmeticException](divideExact(maxDay, 0.5))
}

test("SPARK-34605: microseconds to duration") {
assert(microsToDuration(0).isZero)
assert(microsToDuration(-1).toNanos === -1000)
assert(microsToDuration(1).toNanos === 1000)
assert(microsToDuration(Long.MaxValue).toDays === 106751991)
assert(microsToDuration(Long.MinValue).toDays === -106751991)
}

test("SPARK-34605: duration to microseconds") {
assert(durationToMicros(Duration.ZERO) === 0)
assert(durationToMicros(Duration.ofSeconds(-1)) === -1000000)
assert(durationToMicros(Duration.ofNanos(123456)) === 123)
assert(durationToMicros(Duration.ofDays(106751991)) ===
(Long.MaxValue / MICROS_PER_DAY) * MICROS_PER_DAY)

val errMsg = intercept[ArithmeticException] {
durationToMicros(Duration.ofDays(106751991 + 1))
}.getMessage
assert(errMsg.contains("long overflow"))
}
}