Skip to content

[SPARK-34677][SQL] Support the +/- operators over ANSI SQL intervals #31789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MaxGekk wants to merge 7 commits into from
Closed

[SPARK-34677][SQL] Support the +/- operators over ANSI SQL intervals #31789

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a5fc2c1
Negate intervals
MaxGekk Mar 9, 2021
5bb4b7c
Support +/-
MaxGekk Mar 9, 2021
18b1db3
Regen expected error message
MaxGekk Mar 9, 2021
0a202f3
Reuse exactMathMethod()
MaxGekk Mar 10, 2021
fc4a76d
Remove 's'
MaxGekk Mar 10, 2021
9a086f3
Move UnaryMinus inside of foreach
MaxGekk Mar 11, 2021
3994b69
sumDF -> addDF
MaxGekk Mar 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove 's'
  • Loading branch information
@MaxGekk
MaxGekk committed Mar 10, 2021
commit fc4a76db4d3f4f2db20a2111ee31e9f0e3b50427
2 changes: 1 addition & 1 deletion sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ abstract class BinaryArithmetic extends BinaryOperator with NullIntolerant {
case DayTimeIntervalType | YearMonthIntervalType =>
assert(exactMathMethod.isDefined,
s"The expression '$nodeName' must override the exactMathMethod() method " +
s"if it is supposed to operate over interval types.")
"if it is supposed to operate over interval types.")
val mathClass = classOf[Math].getName
defineCodeGen(ctx, ev, (eval1, eval2) => s"$mathClass.${exactMathMethod.get}($eval1, $eval2)")
// byte and short are casted into int when add, minus, times or divide
Expand Down