Skip to content

[SPARK-34596][SQL][2.4] Use Utils.getSimpleName to avoid hitting Malformed class name in NewInstance.doGenCode #31888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
maropu wants to merge 3 commits into from
Closed

[SPARK-34596][SQL][2.4] Use Utils.getSimpleName to avoid hitting Malformed class name in NewInstance.doGenCode #31888

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3f13d56
[SPARK-34596][SQL] Use Utils.getSimpleName to avoid hitting Malformed…
rednaxelafx Mar 3, 2021
ab77ddb
Minor fix
maropu Mar 19, 2021
5152fff
Add comment
maropu Mar 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add comment
  • Loading branch information
@maropu
maropu committed Mar 20, 2021
commit 5152fffc7344f98d1c9c83d35f219e2855bc4cff
4 changes: 4 additions & 0 deletions ...talyst/src/test/scala/org/apache/spark/sql/catalyst/encoders/ExpressionEncoderSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,10 @@ class ExpressionEncoderSuite extends CodegenInterpretedPlanTest with AnalysisTes

encodeDecodeTest(Array(Option(InnerClass(1))), "array of optional inner class")

// NOTE: branch-2.4 does not have the interpreted implementation of SafeProjection, so
// it does not fall back into the interpreted mode if the compilation fails.
// Therefore, the test in this PR just checks that the compilation error happens
// instead of checking that the interpreted mode works well.
private def checkCompilationError[T : ExpressionEncoder](
input: T,
testName: String): Unit = {
Expand Down