Skip to content

[SPARK-34923][SQL] Metadata output should be empty for more plans #32017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
karenfeng wants to merge 9 commits into from
+132 −1
Closed

[SPARK-34923][SQL] Metadata output should be empty for more plans #32017

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6b4cba3
Metadata output should be empty by default
karenfeng Mar 31, 2021
6c3dde2
Clean up
karenfeng Mar 31, 2021
ce3ac0e
Revert unintended change
karenfeng Apr 1, 2021
a2d72ef
Address comments and merge conflicts
karenfeng Apr 1, 2021
a4a7d05
By default, propagate metadata output
karenfeng Apr 5, 2021
5a04a7e
Use blocklist
karenfeng Apr 5, 2021
73219d4
Retrigger tests
karenfeng Apr 5, 2021
b1c0183
Retrigger tests
karenfeng Apr 6, 2021
e8e6e7d
Retrigger tests
karenfeng Apr 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Clean up 
Signed-off-by: Karen Feng <[email protected]>
  • Loading branch information
@karenfeng
karenfeng committed Mar 31, 2021
commit 6c3dde274e36ab5665b72703435b41332ef60f65
9 changes: 5 additions & 4 deletions ...st/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,8 +111,10 @@ case class Generate(

val unrequiredSet: Set[Int] = unrequiredChildIndex.toSet
Copy link
Contributor

@cloud-fan cloud-fan Apr 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems not needed.


lazy val requiredChildOutput: Seq[Attribute] =
lazy val requiredChildOutput: Seq[Attribute] = {
val unrequiredSet = unrequiredChildIndex.toSet
child.output.zipWithIndex.filterNot(t => unrequiredSet.contains(t._2)).map(_._1)
}

override lazy val resolved: Boolean = {
generator.resolved &&
Expand All @@ -136,8 +138,7 @@ case class Generate(
}

def output: Seq[Attribute] = requiredChildOutput ++ qualifiedGeneratorOutput
override def metadataOutput: Seq[Attribute] =
child.metadataOutput.zipWithIndex.filterNot(t => unrequiredSet.contains(t._2)).map(_._1)
override def metadataOutput: Seq[Attribute] = child.metadataOutput
}

case class Filter(condition: Expression, child: LogicalPlan)
Expand Down Expand Up @@ -376,7 +377,7 @@ case class Join(

override def metadataOutput: Seq[Attribute] = {
joinType match {
case j: ExistenceJoin =>
case ExistenceJoin(_) =>
left.metadataOutput
case LeftExistence(_) =>
left.metadataOutput
Expand Down