Skip to content

[SPARK-34949][CORE] Prevent BlockManager reregister when Executor is shutting down #32043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sumeetgajjar wants to merge 3 commits into from
Closed

[SPARK-34949][CORE] Prevent BlockManager reregister when Executor is shutting down #32043

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5b224a7
Do not reregister BlockManager with Executor is shutting down
sumeetgajjar Apr 3, 2021
c941914
Fix indentation
sumeetgajjar Apr 3, 2021
69a784a
Fix assertion clue
sumeetgajjar Apr 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix assertion clue
  • Loading branch information
@sumeetgajjar
sumeetgajjar committed Apr 5, 2021
commit 69a784a1d3f6b92dea704661100160df137f1078
6 changes: 3 additions & 3 deletions core/src/test/scala/org/apache/spark/executor/ExecutorSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -440,14 +440,14 @@ class ExecutorSuite extends SparkFunSuite
}
val reportHeartbeat = PrivateMethod[Unit](Symbol("reportHeartBeat"))
executor.invokePrivate(reportHeartbeat())
assert(reregisterInvoked.get(),
"BlockManager.reregister not invoked when reregisterBlockManager was true")
assert(reregisterInvoked.get(), "BlockManager.reregister should be invoked " +
"on HeartbeatResponse(reregisterBlockManager = true) when executor is not shutting down")

reregisterInvoked.getAndSet(false)
executor.stop()
executor.invokePrivate(reportHeartbeat())
assert(!reregisterInvoked.get(),
"BlockManager.reregister should not be invoked when executor is stopping")
"BlockManager.reregister should not be invoked when executor is shutting down")
}
}
}
Expand Down