Skip to content

Conversation

@gengliangwang
Copy link
Member

Let's verify the new process from #32092

@gengliangwang
Copy link
Member Author

GA starts: https://github.com/gengliangwang/spark/actions/runs/747046279

@SparkQA
Copy link

SparkQA commented Apr 14, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41903/

@dongjoon-hyun
Copy link
Member

Thank you, @gengliangwang . :)

@dongjoon-hyun
Copy link
Member

BTW, just a question, for the failed GA, only the owner can re-trigger it because it's running on his repo, @HyukjinKwon and @gengliangwang ?

@HyukjinKwon
Copy link
Member

Ah.. good point. Yeah ..

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
checkAnswer(queryCoalesce, Row("2") :: Nil)
checkAnswer(queryCoalesce, Row("2") :: Nil)

Copy link
Member

@HyukjinKwon HyukjinKwon Apr 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the worst case (e.g., author is inactive but PR is ready .. ?), we could push an empty commit to their branch to retrigger .. of course this is an ugly way though

@SparkQA
Copy link

SparkQA commented Apr 14, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41903/

@gengliangwang
Copy link
Member Author

gengliangwang commented Apr 14, 2021

BTW, just a question, for the failed GA, only the owner can re-trigger it because it's running on his repo, @HyukjinKwon and @gengliangwang ?

In the worst case (e.g., author is inactive but PR is ready .. ?), we could push an empty commit to their branch to retrigger .. of course this is an ugly way though

That's true.
How about having a backdoor that triggers the test in Apache/Spark upon certain comments? Similar to what we did for Jenkins: "ok to test"/"retest this please"

@HyukjinKwon
Copy link
Member

I'm not sure if that's feasible or not but that would be great to have it.

@Ngone51
Copy link
Member

Ngone51 commented Apr 14, 2021

I can't see the comment from github-actions as it did in HyukjinKwon#34. Is it supposed to comment after testing finished or only in certain cases?

@HyukjinKwon
Copy link
Member

The comment will be added by "Notify test workflow" job later. There are too many jobs in the queue so it's not triggered yet ...

@Ngone51
Copy link
Member

Ngone51 commented Apr 14, 2021

Got it, thanks @HyukjinKwon

@SparkQA
Copy link

SparkQA commented Apr 14, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41909/

@SparkQA
Copy link

SparkQA commented Apr 14, 2021

Test build #137323 has finished for PR 32158 at commit 9536df2.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Apr 14, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41909/

@SparkQA
Copy link

SparkQA commented Apr 14, 2021

Test build #137329 has finished for PR 32158 at commit 9536df2.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@github-actions
Copy link

Test build #747046279 for PR 32158 at commit 9536df2.

@SparkQA
Copy link

SparkQA commented Apr 14, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41945/

@SparkQA
Copy link

SparkQA commented Apr 14, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41945/

@SparkQA
Copy link

SparkQA commented Apr 14, 2021

Test build #137367 has finished for PR 32158 at commit 8a79b5e.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@github-actions
Copy link

Test build #749195392 for PR 32158 at commit edf2178.

@github-actions
Copy link

Test build #749195392 for PR 32158 at commit 8a79b5e.

@github-actions
Copy link

Test build #755330484 for PR 32158 at commit fc61869.

@SparkQA
Copy link

SparkQA commented Apr 16, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42058/

@SparkQA
Copy link

SparkQA commented Apr 16, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42058/

@SparkQA
Copy link

SparkQA commented Apr 16, 2021

Test build #137483 has finished for PR 32158 at commit fc61869.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member

Do we need to test this more, @gengliangwang ?

@gengliangwang
Copy link
Member Author

It should be fine now. Let me close it.

@gengliangwang gengliangwang deleted the tryNewGA branch April 20, 2021 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants