Skip to content

[SPARK-35112][SQL] Support Cast string to day-second interval #32271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AngersZhuuuu wants to merge 15 commits into from
Closed

[SPARK-35112][SQL] Support Cast string to day-second interval #32271

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
2af65de
[SPARK-35111][SQL] Support Cast string to day-second interval
AngersZhuuuu Apr 21, 2021
b41fd25
fix
AngersZhuuuu Apr 21, 2021
a82bfee
update
AngersZhuuuu Apr 28, 2021
e0b3b30
save
AngersZhuuuu Apr 29, 2021
616380e
save
AngersZhuuuu Apr 29, 2021
35dd9f4
update
AngersZhuuuu Apr 29, 2021
daa9675
done
AngersZhuuuu Apr 29, 2021
c2c7021
update
AngersZhuuuu Apr 30, 2021
700efa4
update
AngersZhuuuu Apr 30, 2021
6ff0522
Merge branch 'master' into SPARK-35112
AngersZhuuuu Apr 30, 2021
9fe4c38
save
AngersZhuuuu May 1, 2021
46fff9c
Update CastSuite.scala
AngersZhuuuu May 1, 2021
50addb4
Update IntervalUtils.scala
AngersZhuuuu May 1, 2021
4f8fc78
Update sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expr…
AngersZhuuuu May 1, 2021
4e2608c
Done
AngersZhuuuu May 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
save
  • Loading branch information
@AngersZhuuuu
AngersZhuuuu committed Apr 29, 2021
commit 616380e52783590d616159f8e871d3950cbd8890
16 changes: 3 additions & 13 deletions sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -902,7 +902,7 @@ abstract class CastBase extends UnaryExpression with TimeZoneAwareExpression wit
case decimal: DecimalType => castToDecimalCode(from, decimal, ctx)
case TimestampType => castToTimestampCode(from, ctx)
case CalendarIntervalType => castToIntervalCode(from)
case DayTimeIntervalType => castToDayTimeIntervalCode(from, ctx)
case DayTimeIntervalType => castToDayTimeIntervalCode(from)
case BooleanType => castToBooleanCode(from)
case ByteType => castToByteCode(from, ctx)
case ShortType => castToShortCode(from, ctx)
Expand Down Expand Up @@ -1361,21 +1361,11 @@ abstract class CastBase extends UnaryExpression with TimeZoneAwareExpression wit

}

private[this] def castToDayTimeIntervalCode(
from: DataType,
ctx: CodegenContext): CastFunction = from match {
private[this] def castToDayTimeIntervalCode(from: DataType): CastFunction = from match {
case StringType =>
val util = IntervalUtils.getClass.getCanonicalName.stripSuffix("$")
val longOpt = ctx.freshVariable("intOpt", classOf[Option[Long]])
(c, evPrim, evNull) =>
code"""
scala.Option<Long> $longOpt = $util.castStringToDTInterval($c).microseconds;
if ($longOpt.isDefined()) {
$evPrim = ((Long) $longOpt.get()).longValue();
} else {
$evNull = true;
}
""".stripMargin
code"$evPrim = $util.castStringToDTInterval($c).microseconds;"
}

private[this] def decimalToTimestampCode(d: ExprValue): Block = {
Expand Down
15 changes: 8 additions & 7 deletions sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/IntervalUtils.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,19 +131,20 @@ object IntervalUtils {
def castStringToDTInterval(input: UTF8String): CalendarInterval = {
val intervalStr = input.trimAll().toString.toUpperCase(Locale.ROOT)
intervalStr match {
case dayTimePatternLegacy(_, _, _, _, _, _) =>
fromDayTimeString(intervalStr)
case daySecondStringPattern(_, prefixSign, _, suffixSign, _, _, _, _, _, _, _) =>
case daySecondNumPattern(_, _, _, _, _, _) =>
fromDayTimeString(intervalStr, DAY, SECOND)
case daySecondNumPattern(_, prefixSign, _, suffixSign, _, _, _, _, _, _, _) =>
val dtStr =
"^([+|-])".r.replaceAllIn(daySecondNumPattern.findFirstIn(intervalStr).get, "")
(prefixSign, suffixSign) match {
case ("-", "-") => fromDayTimeString(dtStr)
case ("-", _) => fromDayTimeString(s"-$dtStr")
case (_, _) => fromDayTimeString(dtStr)
case ("-", "-") => fromDayTimeString(dtStr, DAY, SECOND)
case ("-", _) => fromDayTimeString(s"-$dtStr", DAY, SECOND)
case (_, _) => fromDayTimeString(dtStr, DAY, SECOND)
}
case daySecondStringPattern(_, null, _, _, _, _, _, _, _, _, _) =>
val dtStr = daySecondNumPattern.findFirstIn(intervalStr).get
fromDayTimeString(dtStr)
println(dtStr)
fromDayTimeString(dtStr, DAY, SECOND)
case daySecondStringPattern(_, _, _, _, _, _, _, _, _, _, _) =>
throw new IllegalArgumentException(
s"Interval string must match day-time format of 'd h:m:s.n': ${input.toString}, " +
Expand Down