Skip to content

[SPARK-35088][SQL] Accept ANSI intervals by the Sequence expression #32311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
beliefer wants to merge 6 commits into from
Closed

[SPARK-35088][SQL] Accept ANSI intervals by the Sequence expression #32311

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1e96d54
Accept ANSI intervals by the Sequence expression
beliefer Apr 23, 2021
89a34bc
Fix scala style
beliefer Apr 23, 2021
1d38d02
Update code
beliefer Apr 25, 2021
75562fe
Fix scala style
beliefer Apr 25, 2021
cb361d1
Improve the error msg.
beliefer Apr 25, 2021
47853e8
Update code
beliefer Apr 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update code
  • Loading branch information
@beliefer
beliefer committed Apr 26, 2021
commit 47853e8610a0bf37d377b552cdf6739b3cbeee36
14 changes: 8 additions & 6 deletions ...alyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2484,8 +2484,8 @@ case class Flatten(child: Expression) extends UnaryExpression with NullIntoleran

The start and stop expressions must resolve to the same type.
If start and stop expressions resolve to the 'date' or 'timestamp' type
then the step expression must resolve to the 'interval' or 'year-month' or 'day-time' type,
otherwise to the same type as the start and stop expressions.
then the step expression must resolve to the 'interval' or 'year-month interval' or
'day-time interval' type, otherwise to the same type as the start and stop expressions.
""",
arguments = """
Arguments:
Expand Down Expand Up @@ -2572,8 +2572,9 @@ case class Sequence(
|$prettyName uses the wrong parameter type. The parameter type must conform to:
|1. The start and stop expressions must resolve to the same type.
|2. If start and stop expressions resolve to the 'date' or 'timestamp' type
|then the step expression must resolve to the 'interval' or 'year-month' or
|'day-time' type, otherwise to the same type as the start and stop expressions.
|then the step expression must resolve to the 'interval' or
|'${YearMonthIntervalType.typeName}' or '${DayTimeIntervalType.typeName}' type,
|otherwise to the same type as the start and stop expressions.
""".stripMargin)
}
}
Expand Down Expand Up @@ -2917,8 +2918,9 @@ object Sequence {
s"""
|final long $intervalInMicros =
| $stepMicros + $stepMonths * ${microsPerMonth}L + $stepDays * ${MICROS_PER_DAY}L;
|${genSequenceLengthCode(ctx, startMicros, stopMicros, step, intervalInMicros, arrLength)}
""".stripMargin
|${genSequenceLengthCode(
ctx, startMicros, stopMicros, step, intervalInMicros, arrLength)}
""".stripMargin

val check = if (scale == MICROS_PER_DAY) {
s"""
Expand Down