Skip to content

Conversation

@sarutak
Copy link
Member

@sarutak sarutak commented Apr 24, 2021

What changes were proposed in this pull request?

This PR proposes to upgrade Jetty to 9.4.40.

Why are the changes needed?

SPARK-34988 (#32091) upgraded Jetty to 9.4.39 for CVE-2021-28165.
But after the upgrade, Jetty 9.4.40 was released to fix the ERR_CONNECTION_RESET issue (jetty/jetty.project#6152).
This issue seems to affect Jetty 9.4.39 when POST method is used with SSL.
For Spark, job submission using REST and ThriftServer with HTTPS protocol can be affected.

Does this PR introduce any user-facing change?

No. No released version uses Jetty 9.3.39.

How was this patch tested?

CI.

@github-actions github-actions bot added the BUILD label Apr 24, 2021
@sarutak
Copy link
Member Author

sarutak commented Apr 24, 2021

@viirya
Copy link
Member

viirya commented Apr 24, 2021

[CORE]? [BUILD]?

@SparkQA
Copy link

SparkQA commented Apr 24, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42406/

@SparkQA
Copy link

SparkQA commented Apr 24, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42406/

@sarutak sarutak changed the title [SPARK-35210][CORE] Upgrade Jetty to 9.4.40 to fix ERR_CONNECTION_RESET issue [SPARK-35210][BUILD] Upgrade Jetty to 9.4.40 to fix ERR_CONNECTION_RESET issue Apr 24, 2021
Copy link
Member

@viirya viirya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks okay to me.

@SparkQA
Copy link

SparkQA commented Apr 24, 2021

Test build #137876 has finished for PR 32318 at commit 215a72d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@sarutak sarutak closed this in 44c1387 Apr 24, 2021
@sarutak
Copy link
Member Author

sarutak commented Apr 24, 2021

Merged to master.
I'll also open PRs to backport this change for branch-3.1, branch-3.0 and branch-2.4.

Copy link
Member

@srowen srowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, yes back port it

viirya pushed a commit that referenced this pull request Apr 24, 2021
…ON_RESET issue

### What changes were proposed in this pull request?

This PR backports SPARK-35210 (#32318).
This PR proposes to upgrade Jetty to 9.4.40.

### Why are the changes needed?

SPARK-34988 (#32091) upgraded Jetty to 9.4.39 for CVE-2021-28165.
But after the upgrade, Jetty 9.4.40 was released to fix the ERR_CONNECTION_RESET issue (jetty/jetty.project#6152).
This issue seems to affect Jetty 9.4.39 when POST method is used with SSL.
For Spark, job submission using REST and ThriftServer with HTTPS protocol can be affected.

### Does this PR introduce _any_ user-facing change?

No. No released version uses Jetty 9.3.39.

### How was this patch tested?

CI.

Closes #32324 from sarutak/backport-3.1-SPARK-35210.

Authored-by: Kousuke Saruta <[email protected]>
Signed-off-by: Liang-Chi Hsieh <[email protected]>
@dongjoon-hyun
Copy link
Member

+1, late LGTM.

viirya pushed a commit that referenced this pull request Apr 24, 2021
…ON_RESET issue

### What changes were proposed in this pull request?

This PR backports SPARK-35210 (#32318).
This PR proposes to upgrade Jetty to 9.4.40.

### Why are the changes needed?

SPARK-34988 (#32091) upgraded Jetty to 9.4.39 for CVE-2021-28165.
But after the upgrade, Jetty 9.4.40 was released to fix the ERR_CONNECTION_RESET issue (jetty/jetty.project#6152).
This issue seems to affect Jetty 9.4.39 when POST method is used with SSL.
For Spark, job submission using REST and ThriftServer with HTTPS protocol can be affected.

### Does this PR introduce _any_ user-facing change?

No. No released version uses Jetty 9.3.39.

### How was this patch tested?

CI.

Closes #32323 from sarutak/backport-3.0-SPARK-35210.

Authored-by: Kousuke Saruta <[email protected]>
Signed-off-by: Liang-Chi Hsieh <[email protected]>
viirya pushed a commit that referenced this pull request Apr 25, 2021
…ON_RESET issue

### What changes were proposed in this pull request?

This PR backports SPARK-35210 (#32318).
This PR proposes to upgrade Jetty to 9.4.40.

### Why are the changes needed?

SPARK-34988 (#32091) upgraded Jetty to 9.4.39 for CVE-2021-28165.
But after the upgrade, Jetty 9.4.40 was released to fix the ERR_CONNECTION_RESET issue (jetty/jetty.project#6152).
This issue seems to affect Jetty 9.4.39 when POST method is used with SSL.
For Spark, job submission using REST and ThriftServer with HTTPS protocol can be affected.

### Does this PR introduce _any_ user-facing change?

No. No released version uses Jetty 9.3.39.

### How was this patch tested?

CI.

Closes #32322 from sarutak/backport-SPARK-35210.

Authored-by: Kousuke Saruta <[email protected]>
Signed-off-by: Liang-Chi Hsieh <[email protected]>
flyrain pushed a commit to flyrain/spark that referenced this pull request Sep 21, 2021
…ON_RESET issue

This PR backports SPARK-35210 (apache#32318).
This PR proposes to upgrade Jetty to 9.4.40.

SPARK-34988 (apache#32091) upgraded Jetty to 9.4.39 for CVE-2021-28165.
But after the upgrade, Jetty 9.4.40 was released to fix the ERR_CONNECTION_RESET issue (jetty/jetty.project#6152).
This issue seems to affect Jetty 9.4.39 when POST method is used with SSL.
For Spark, job submission using REST and ThriftServer with HTTPS protocol can be affected.

No. No released version uses Jetty 9.3.39.

CI.

Closes apache#32324 from sarutak/backport-3.1-SPARK-35210.

Authored-by: Kousuke Saruta <[email protected]>
Signed-off-by: Liang-Chi Hsieh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants