Skip to content

[SPARK-35220][SQL] DayTimeIntervalType/YearMonthIntervalType show different between Hive SerDe and row format delimited #32335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AngersZhuuuu wants to merge 2 commits into from
Closed

[SPARK-35220][SQL] DayTimeIntervalType/YearMonthIntervalType show different between Hive SerDe and row format delimited #32335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab94c21
[SPARK-35220][SQL] DayTimeIntervalType/YearMonthIntervalString show d…
AngersZhuuuu Apr 25, 2021
9f1bd02
Update BaseScriptTransformationSuite.scala
AngersZhuuuu Apr 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions sql/core/src/test/scala/org/apache/spark/sql/execution/BaseScriptTransformationSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
package org.apache.spark.sql.execution

import java.sql.{Date, Timestamp}
import java.time.{Duration, Period}

import org.json4s.DefaultFormats
import org.json4s.JsonDSL._
Expand All @@ -43,6 +44,8 @@ abstract class BaseScriptTransformationSuite extends SparkPlanTest with SQLTestU
import testImplicits._
import ScriptTransformationIOSchema._

protected def defaultSerDe(): String

protected val uncaughtExceptionHandler = new TestUncaughtExceptionHandler

private var defaultUncaughtExceptionHandler: Thread.UncaughtExceptionHandler = _
Expand Down Expand Up @@ -599,6 +602,37 @@ abstract class BaseScriptTransformationSuite extends SparkPlanTest with SQLTestU
'e.cast("string")).collect())
}
}

test("SPARK-35220: DayTimeIntervalType/YearMonthIntervalType show different " +
"between hive serde and row format delimited\t") {
assume(TestUtils.testCommandAvailable("/bin/bash"))
withTempView("v") {
val df = Seq(
(Duration.ofDays(1), Period.ofMonths(10))
).toDF("a", "b")
df.createTempView("v")

if (defaultSerDe == "hive-serde") {
checkAnswer(sql(
"""
|SELECT TRANSFORM(a, b)
| USING 'cat' AS (a, b)
|FROM v
|""".stripMargin),
identity,
Row("1 00:00:00.000000000", "0-10") :: Nil)
} else {
checkAnswer(sql(
"""
|SELECT TRANSFORM(a, b)
| USING 'cat' AS (a, b)
|FROM v
|""".stripMargin),
identity,
Row("INTERVAL '1 00:00:00' DAY TO SECOND", "INTERVAL '0-10' YEAR TO MONTH") :: Nil)
Copy link
Contributor

@cloud-fan cloud-fan Apr 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so the spark-sql shell and df.show have different formats for intervals?

Copy link
Contributor Author

@AngersZhuuuu AngersZhuuuu Apr 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so the spark-sql shell and df.show have different formats for intervals?

Yea, have this problem too, since spark sql follow hive format. What should I to do next?

Copy link
Contributor

@cloud-fan cloud-fan Apr 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is interval format the only difference between hive format and spark cast?

Copy link
Contributor Author

@AngersZhuuuu AngersZhuuuu Apr 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is interval format the only difference between hive format and spark cast?

Yea， ANSI_STYLE and HIVE_STYLE

Copy link
Contributor

@cloud-fan cloud-fan Apr 26, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should have a new Expression ToHiveString and use it in df.show and TRANSFORM, so that they are consistent.

Copy link
Contributor Author

@AngersZhuuuu AngersZhuuuu Apr 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should have a new Expression ToHiveString and use it in df.show and TRANSFORM, so that they are consistent.

Yea, create a ticket https://issues.apache.org/jira/browse/SPARK-35228

}
}
}
}

case class ExceptionInjectingOperator(child: SparkPlan) extends UnaryExecNode {
Expand Down
2 changes: 2 additions & 0 deletions sql/core/src/test/scala/org/apache/spark/sql/execution/SparkScriptTransformationSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ import org.apache.spark.sql.test.SharedSparkSession
class SparkScriptTransformationSuite extends BaseScriptTransformationSuite with SharedSparkSession {
import testImplicits._

override protected def defaultSerDe(): String = "row-format-delimited"

override def createScriptTransformationExec(
script: String,
output: Seq[Attribute],
Expand Down
2 changes: 2 additions & 0 deletions ...ve/src/test/scala/org/apache/spark/sql/hive/execution/HiveScriptTransformationSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@ class HiveScriptTransformationSuite extends BaseScriptTransformationSuite with T

import ScriptTransformationIOSchema._

override protected def defaultSerDe(): String = "hive-serde"

override def createScriptTransformationExec(
script: String,
output: Seq[Attribute],
Expand Down