Skip to content

Conversation

@jerqi
Copy link
Contributor

@jerqi jerqi commented May 3, 2021

What changes were proposed in this pull request?

Now Spark Executor already can be used in Kubernetes scheduler. So we should modify the annotation in the Executor.scala.

Why are the changes needed?

only comment

Does this PR introduce any user-facing change?

no

How was this patch tested?

no

@github-actions github-actions bot added the CORE label May 3, 2021
@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@jerqi jerqi closed this May 4, 2021
@jerqi jerqi reopened this May 4, 2021
@jerqi jerqi changed the title [SPARK-35297][DOC] modify the annotation about the executor [SPARK-35297][DOC] modify the comment about the executor May 4, 2021
@jerqi jerqi closed this May 4, 2021
@jerqi jerqi reopened this May 4, 2021
@jerqi jerqi force-pushed the master branch 2 times, most recently from 2d717d5 to 696f3b3 Compare May 4, 2021 05:38
@jerqi
Copy link
Contributor Author

jerqi commented May 5, 2021

cc @dongjoon-hyun

@maropu
Copy link
Member

maropu commented May 6, 2021

The fix itself looks fine. If a fix is trivial, we don't need to file jira, I think. Have you checked that the other places don't have a similar issue?

@maropu maropu changed the title [SPARK-35297][DOC] modify the comment about the executor [SPARK-35297][CORE][DOC][MINOR] Modify the comment about the executor May 6, 2021
@jerqi
Copy link
Contributor Author

jerqi commented May 6, 2021

Have you checked that the other places don't have a similar issue

I have checked that the other places don't have a similar issue

@maropu maropu closed this in 6f0ef93 May 7, 2021
@maropu
Copy link
Member

maropu commented May 7, 2021

Merged to mater. Thank you, @jerqi

@dongjoon-hyun
Copy link
Member

+1, late LGTM. Thank you, @jerqi and @maropu .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants