[SPARK-35111][SPARK-35112][SQL][FOLLOWUP] Rename ANSI interval patterns and regexps #32444
Conversation
|
FYI @MaxGekk |
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
Test build #138177 has finished for PR 32444 at commit
|
AngersZhuuuu
changed the title
| private val yearMonthStringPattern = | ||
| "(?i)^(INTERVAL\\s+)([+|-])?(')([+|-])?(\\d+)-(\\d+)(')(\\s+YEAR\\s+TO\\s+MONTH)$".r | ||
| private val unquotedYearMonthRegex = "([+|-])?(\\d+)-(\\d+)".r | ||
| private val quotedYearMonthPattern = (s"^$unquotedYearMonthRegex$$").r |
There was a problem hiding this comment.
I don't really see what "quoted" means here...
There was a problem hiding this comment.
I don't really see what "quoted" means here...
he may want to mean it without ^ and $
There was a problem hiding this comment.
that's not quoted. To me it's more like regex string vs compiled regex.
How about yearMonthPatternString, yearMonthRegex and yearMontnLiteralRegex?
There was a problem hiding this comment.
Look good, done
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
Test build #138252 has finished for PR 32444 at commit
|
|
Test build #138254 has finished for PR 32444 at commit
|
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
Test build #138274 has finished for PR 32444 at commit
|
MaxGekk
changed the title
|
+1, LGTM. Merging to master. |
4 participants
What changes were proposed in this pull request?
Rename pattern strings and regexps of year-month and day-time intervals.
Why are the changes needed?
To improve code maintainability.
Does this PR introduce any user-facing change?
No
How was this patch tested?
By existing test suites.