-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-35331][SQL] Support resolving missing attrs for distribute/cluster by/repartition hint #32465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
cc @cloud-fan @maropu @HyukjinKwon thanks for reviewing |
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
is this a regression? It seems to me that this should fail, as it's similar to |
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
this is not a regression, but hive supports it.
For resolving attributes, |
|
Test build #138231 has finished for PR 32465 at commit
|
|
Test build #138234 has finished for PR 32465 at commit
|
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @yaooqinn .
As you mentioned, this is not a regression and didn't work before. I believe this should be merged as a new improvement to Apache Spark 3.2.0.
| } | ||
| } | ||
|
|
||
| test("SPARK-35331: Fix resolving original expression in RepartitionByExpression after aliased") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you don't mind, could you add a test case for HINT explicitly?
|
Thank you for adding a test, @yaooqinn . |
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
It's my pleasure |
OK~ |
|
Test build #138273 has finished for PR 32465 at commit
|
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
Merged to master. Thank you, @yaooqinn and @cloud-fan . |
|
Test build #138288 has finished for PR 32465 at commit
|
What changes were proposed in this pull request?
This PR makes the below case work well.
Why are the changes needed?
bugfix
Does this PR introduce any user-facing change?
yes, the original attributes can be used in
distribute by/cluster byand hints like/*+ REPARTITION(3, c) */How was this patch tested?
new tests