Skip to content

[SPARK-35207][SQL] Normalize hash function behavior with negative zero (floating point types) #32496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
planga82 wants to merge 6 commits into from
Closed

[SPARK-35207][SQL] Normalize hash function behavior with negative zero (floating point types) #32496

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f86fba6
Changes implementation
planga82 May 11, 2021
641629d
Style corrections
planga82 May 12, 2021
a671ce7
Merge remote-tracking branch 'upstream/master' into feature/spark3520…
planga82 May 13, 2021
1de9c3d
Improve solution
planga82 May 13, 2021
869ae7c
Update migration guide
planga82 May 14, 2021
c123599
Simplify expressions
planga82 May 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Simplify expressions
  • Loading branch information
@planga82
planga82 committed May 14, 2021
commit c123599da608adf219304b1409279abfd38b114c
8 changes: 4 additions & 4 deletions sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/hash.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,7 +372,7 @@ abstract class HashExpression[E] extends Expression {
protected def genHashFloat(input: String, result: String): String = {
s"""
|if($input == -0.0f) {
| ${genHashInt(s"Float.floatToIntBits(0.0f)", result)}
| ${genHashInt("0", result)}
|} else {
| ${genHashInt(s"Float.floatToIntBits($input)", result)}
|}
Expand All @@ -382,7 +382,7 @@ abstract class HashExpression[E] extends Expression {
protected def genHashDouble(input: String, result: String): String = {
s"""
|if($input == -0.0d) {
| ${genHashLong(s"Double.doubleToLongBits(0.0d)", result)}
| ${genHashLong("0L", result)}
|} else {
| ${genHashLong(s"Double.doubleToLongBits($input)", result)}
|}
Expand Down Expand Up @@ -537,9 +537,9 @@ abstract class InterpretedHashFunction {
case s: Short => hashInt(s, seed)
case i: Int => hashInt(i, seed)
case l: Long => hashLong(l, seed)
case f: Float if (f == -0.0f) => hashInt(java.lang.Float.floatToIntBits(0.0f), seed)
case f: Float if (f == -0.0f) => hashInt(0, seed)
case f: Float => hashInt(java.lang.Float.floatToIntBits(f), seed)
case d: Double if (d == -0.0d) => hashLong(java.lang.Double.doubleToLongBits(0.0d), seed)
case d: Double if (d == -0.0d) => hashLong(0L, seed)
case d: Double => hashLong(java.lang.Double.doubleToLongBits(d), seed)
case d: Decimal =>
val precision = dataType.asInstanceOf[DecimalType].precision
Expand Down