Skip to content

[SPARK-4397][Core] Reorganize 'implicit's to improve the API convenience #3262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zsxwing wants to merge 11 commits into from
Closed

[SPARK-4397][Core] Reorganize 'implicit's to improve the API convenience #3262

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
1eda9e4
Reorganize 'implicit's to improve the API convenience
zsxwing Nov 14, 2014
3ac4f07
Add license header
zsxwing Nov 14, 2014
9b73188
Fix the code style issue
zsxwing Nov 14, 2014
3bdcae2
Move WritableConverter implicits to object WritableConverter
zsxwing Nov 14, 2014
185c12f
Remove simpleWritableConverter from SparkContext
zsxwing Nov 15, 2014
7266218
Add comments to warn the duplicate codes in SparkContext
zsxwing Nov 15, 2014
34641d4
Move ImplicitSuite to org.apache.sparktest
zsxwing Nov 16, 2014
52353de
Remove private[spark] from object WritableConverter
zsxwing Nov 17, 2014
2b5f5a4
Comments for the deprecated functions
zsxwing Nov 17, 2014
9c27aff
Move implicit functions to object RDD and forward old functions to ne…
zsxwing Nov 17, 2014
fc30314
Update the comments
zsxwing Nov 21, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove private[spark] from object WritableConverter
  • Loading branch information
@zsxwing
zsxwing committed Nov 17, 2014
commit 52353deb3612daae91fe32ed3a774f90620c29f0
2 changes: 1 addition & 1 deletion core/src/main/scala/org/apache/spark/SparkContext.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1781,7 +1781,7 @@ private[spark] class WritableConverter[T](
val convert: Writable => T)
extends Serializable

private[spark] object WritableConverter {
object WritableConverter {

// Helper objects for converting common types to Writable
private[spark] def simpleWritableConverter[T, W <: Writable: ClassTag](convert: W => T)
Expand Down