[SPARK-35482][K8S][3.0] Use spark.blockManager.port not the wrong spark.blockmanager.port in BasicExecutorFeatureStep
#32624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rk.blockmanager.port in BasicExecutorFeatureStep
|
Test build #138814 has finished for PR 32624 at commit
|
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
Member
Author
dongjoon-hyun
approved these changes
May 22, 2021
Member
There was a problem hiding this comment.
+1, LGTM. Thank you, @yaooqinn .
Merged to branch-3.0.
dongjoon-hyun
pushed a commit
that referenced
this pull request
May 22, 2021
…spark.blockmanager.port` in `BasicExecutorFeatureStep` backport #32621 to 3.0 ### What changes were proposed in this pull request? most spark conf keys are case sensitive, including `spark.blockManager.port`, we can not get the correct port number with `spark.blockmanager.port`. This PR changes the wrong key to `spark.blockManager.port` in `BasicExecutorFeatureStep`. This PR also ensures a fast fail when the port value is invalid for executor containers. When 0 is specified(it is valid as random port, but invalid as a k8s request), it should not be put in the `containerPort` field of executor pod desc. We do not expect executor pods to continuously fail to create because of invalid requests. ### Why are the changes needed? bugfix ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? new tests Closes #32624 from yaooqinn/backport. Authored-by: Kent Yao <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport #32621 to 3.0
What changes were proposed in this pull request?
most spark conf keys are case sensitive, including
spark.blockManager.port, we can not get the correct port number withspark.blockmanager.port.This PR changes the wrong key to
spark.blockManager.portinBasicExecutorFeatureStep.This PR also ensures a fast fail when the port value is invalid for executor containers. When 0 is specified(it is valid as random port, but invalid as a k8s request), it should not be put in the
containerPortfield of executor pod desc. We do not expect executor pods to continuously fail to create because of invalid requests.Why are the changes needed?
bugfix
Does this PR introduce any user-facing change?
no
How was this patch tested?
new tests