Skip to content

Conversation

@WangTaoTheTonic
Copy link
Contributor

...ess ends

https://issues.apache.org/jira/browse/SPARK-4404

When we have spark.driver.extra* or spark.driver.memory in SPARK_SUBMIT_PROPERTIES_FILE, spark-class will use SparkSubmitDriverBootstrapper to launch driver.
If we get process id of SparkSubmitDriverBootstrapper and wanna kill it during its running, we expect its SparkSubmit sub-process stop also.

@SparkQA
Copy link

SparkQA commented Nov 14, 2014

Test build #23371 has started for PR 3266 at commit 57b5ca1.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Nov 14, 2014

Test build #23371 has finished for PR 3266 at commit 57b5ca1.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23371/
Test PASSed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to name this thread. Also, could you add a comment here to explain that this is for killing the app while it's running? Otherwise it's not clear to me why we need to do this here and do the same at the end of the file again.

@andrewor14
Copy link
Contributor

Hey @WangTaoTheTonic small comment but LGTM.

@WangTaoTheTonic
Copy link
Contributor Author

@andrewor14 Done. Thanks for you review.

@SparkQA
Copy link

SparkQA commented Nov 15, 2014

Test build #23405 has started for PR 3266 at commit e03eba5.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Nov 15, 2014

Test build #23405 has finished for PR 3266 at commit e03eba5.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23405/
Test PASSed.

@andrewor14
Copy link
Contributor

Ok I merge 1.2 master

@asfgit asfgit closed this in 303a4e4 Nov 15, 2014
asfgit pushed a commit that referenced this pull request Nov 15, 2014
…Submit sub-proc...

...ess ends

https://issues.apache.org/jira/browse/SPARK-4404

When we have spark.driver.extra* or spark.driver.memory in SPARK_SUBMIT_PROPERTIES_FILE, spark-class will use SparkSubmitDriverBootstrapper to launch driver.
If we get process id of SparkSubmitDriverBootstrapper and wanna kill it during its running, we expect its SparkSubmit sub-process stop also.

Author: WangTao <[email protected]>
Author: WangTaoTheTonic <[email protected]>

Closes #3266 from WangTaoTheTonic/killsubmit and squashes the following commits:

e03eba5 [WangTaoTheTonic] add comments
57b5ca1 [WangTao] SparkSubmitDriverBootstrapper should stop after its SparkSubmit sub-process ends

(cherry picked from commit 303a4e4)
Signed-off-by: Andrew Or <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants