-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-4404]SparkSubmitDriverBootstrapper should stop after its SparkSubmit sub-proc... #3266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #23371 has started for PR 3266 at commit
|
|
Test build #23371 has finished for PR 3266 at commit
|
|
Test PASSed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to name this thread. Also, could you add a comment here to explain that this is for killing the app while it's running? Otherwise it's not clear to me why we need to do this here and do the same at the end of the file again.
|
Hey @WangTaoTheTonic small comment but LGTM. |
|
@andrewor14 Done. Thanks for you review. |
|
Test build #23405 has started for PR 3266 at commit
|
|
Test build #23405 has finished for PR 3266 at commit
|
|
Test PASSed. |
|
Ok I merge 1.2 master |
…Submit sub-proc... ...ess ends https://issues.apache.org/jira/browse/SPARK-4404 When we have spark.driver.extra* or spark.driver.memory in SPARK_SUBMIT_PROPERTIES_FILE, spark-class will use SparkSubmitDriverBootstrapper to launch driver. If we get process id of SparkSubmitDriverBootstrapper and wanna kill it during its running, we expect its SparkSubmit sub-process stop also. Author: WangTao <[email protected]> Author: WangTaoTheTonic <[email protected]> Closes #3266 from WangTaoTheTonic/killsubmit and squashes the following commits: e03eba5 [WangTaoTheTonic] add comments 57b5ca1 [WangTao] SparkSubmitDriverBootstrapper should stop after its SparkSubmit sub-process ends (cherry picked from commit 303a4e4) Signed-off-by: Andrew Or <[email protected]>
...ess ends
https://issues.apache.org/jira/browse/SPARK-4404
When we have spark.driver.extra* or spark.driver.memory in SPARK_SUBMIT_PROPERTIES_FILE, spark-class will use SparkSubmitDriverBootstrapper to launch driver.
If we get process id of SparkSubmitDriverBootstrapper and wanna kill it during its running, we expect its SparkSubmit sub-process stop also.